Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add overlay MaterialStateProperty property to Slider #112922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Add overlay MaterialStateProperty property to Slider #112922

merged 2 commits into from
Oct 6, 2022

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Oct 5, 2022 •
edited
Loading

fixes #112864

This PR does the following:

  1. Add overlay MaterialStateProperty property.
  2. Add support for material states to SliderTheme.overlay and new Slider.overlay property (move states above so sliderTheme.copyWith can access the states).
  3. Move the Slider uses the right theme colors for the right components theme test from slider_test.dart to slider_theme_test.dart
  4. Remove some blank lines.

This is preliminary work for #111451

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from HansMuller October 5, 2022 08:02
@TahaTesser TahaTesser mentioned this pull request Oct 5, 2022
Closed
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 5, 2022
HansMuller
HansMuller reviewed Oct 5, 2022
View reviewed changes
@TahaTesser TahaTesser requested a review from HansMuller October 5, 2022 19:39
@HansMuller
Copy link
Contributor

Lots of test failures that didn't appear to be related to this PR. I've tried restarting them. You may need to resync with master

HansMuller
HansMuller reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2022
@auto-submit auto-submit bot merged commit ad2005c into flutter:master Oct 6, 2022
This was referenced Oct 6, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2022
@engine-flutter-autoroll
ad2005c Add overlay MaterialStateProperty property to Slider (flu…
df65aff 
…tter/flutter#112922)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 6, 2022
@engine-flutter-autoroll
ad2005c Add overlay MaterialStateProperty property to Slider (flu…
b3873b9 
…tter/flutter#112922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 6, 2022
@engine-flutter-autoroll
ad2005c Add overlay MaterialStateProperty property to Slider (flu…
02b3ad9 
…tter/flutter#112922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 6, 2022
@engine-flutter-autoroll
ad2005c Add overlay MaterialStateProperty property to Slider (flu…
db2e411 
…tter/flutter#112922)
@TahaTesser TahaTesser deleted the slider_overlay branch October 17, 2022 11:32
@TahaTesser TahaTesser mentioned this pull request Oct 31, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing overlay property and support Material states for SliderTheme.overlay
2 participants
@TahaTesser @HansMuller