Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[date_picker] [date_range_picker] add properties to change switch-to icons #124881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2023
Merged

[date_picker] [date_range_picker] add properties to change switch-to icons #124881

merged 4 commits into from
Apr 24, 2023

Conversation

piedcipher
Copy link
Member

@piedcipher piedcipher commented Apr 14, 2023 •
edited
Loading

Adds switchToInputEntryModeIcon & switchToCalendarEntryModeIcon properties to showDatePicker & showDateRangePicker.

Fixes: #122840

showDatePicker

switchToInputEntryModeIcon: default switchToInputEntryModeIcon: Icons.keyboard
dp_switchtoinputentrymodeicon_default dp_switchtoinputentrymodeicon_icon_keyboard
switchToCalendarEntryModeIcon: default switchToCalendarEntryModeIcon: Icons.weekend
dp_switchtocalendarentrymodeicon_default dp_switchtocalendarentrymodeicon_icons_weekend

showDateRangePicker

switchToInputEntryModeIcon: default switchToInputEntryModeIcon: Icons.keyboard
drp_switchtoinputentrymodeicon_default drp_switchtoinputentrymodeicon_icon_keyboard
switchToCalendarEntryModeIcon: default switchToCalendarEntryModeIcon: Icons.weekend
drp_switchtocalendarentrymodeicon_default drp_switchtocalendarentrymodeicon_icons_weekend

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2023
@piedcipher piedcipher force-pushed the enhancement/date_picker_switch_icons branch 8 times, most recently from f897585 to 1735236 Compare April 21, 2023 15:51
@HansMuller HansMuller self-requested a review April 21, 2023 15:58
@piedcipher piedcipher force-pushed the enhancement/date_picker_switch_icons branch 2 times, most recently from 9569794 to 847a1de Compare April 24, 2023 05:12
HansMuller
HansMuller reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just needs a tweak to repeated API doc

@piedcipher piedcipher force-pushed the enhancement/date_picker_switch_icons branch from 847a1de to b5e3d50 Compare April 24, 2023 20:14
HansMuller
HansMuller approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 9525934 into flutter:master Apr 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
c111369 
…itch-to icons (flutter/flutter#124881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
4755f5c 
…itch-to icons (flutter/flutter#124881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
daf6d3b 
…itch-to icons (flutter/flutter#124881)
@piedcipher piedcipher deleted the enhancement/date_picker_switch_icons branch April 25, 2023 18:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
af40efc 
…itch-to icons (flutter/flutter#124881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
ee57885 
…itch-to icons (flutter/flutter#124881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
9525934 [date_picker] [date_range_picker] add properties to change sw…
40421e9 
…itch-to icons (flutter/flutter#124881)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (#3830)
66703bc 
Roll Flutter from c9004ff to 66fa4c5 (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 [email protected] Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 [email protected] Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 [email protected] Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 [email protected] Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 [email protected] Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 [email protected] Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 [email protected] Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 [email protected] Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 [email protected] Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 [email protected] Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 [email protected] Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 [email protected] Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 [email protected] Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 [email protected] Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 [email protected] Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 [email protected] Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 [email protected] Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 [email protected] Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 [email protected] Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 [email protected] Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 [email protected] iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 [email protected] Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 [email protected] Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 [email protected] Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 [email protected] Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 [email protected] Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 [email protected] Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 [email protected] Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 [email protected] Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 [email protected] Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 [email protected] Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 [email protected] Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 [email protected] Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 [email protected] [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 [email protected] Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 [email protected] tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 [email protected] Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 [email protected] Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 [email protected] Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 [email protected] Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 [email protected] Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 [email protected] Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 [email protected] Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 [email protected] [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 [email protected] Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 [email protected] Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
@HansMuller HansMuller mentioned this pull request Apr 28, 2023
Closed
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter#3830)
8844fd8 
Roll Flutter from c9004ff to 66fa4c5 (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 [email protected] Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 [email protected] Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 [email protected] Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 [email protected] Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 [email protected] Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 [email protected] Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 [email protected] Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 [email protected] Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 [email protected] Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 [email protected] Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 [email protected] Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 [email protected] Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 [email protected] Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 [email protected] Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 [email protected] Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 [email protected] Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 [email protected] Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 [email protected] Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 [email protected] Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 [email protected] Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 [email protected] iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 [email protected] Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 [email protected] Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 [email protected] Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 [email protected] Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 [email protected] Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 [email protected] Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 [email protected] Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 [email protected] Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 [email protected] Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 [email protected] Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 [email protected] Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 [email protected] Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 [email protected] [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 [email protected] Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 [email protected] tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 [email protected] Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 [email protected] Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 [email protected] Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 [email protected] Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 [email protected] Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 [email protected] Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 [email protected] Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 [email protected] [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 [email protected] Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 [email protected] Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal to customize date_picker icons
2 participants
@piedcipher @HansMuller