Sliver Constrained Cross Axis #125239

thkim1011 · 2023-04-20T19:12:30Z

Reimplements what we reverted here: #125233.

This reverts commit 9caabdd.

packages/flutter/lib/src/rendering/proxy_sliver.dart

packages/flutter/lib/src/rendering/sliver.dart

packages/flutter/lib/src/widgets/sliver.dart

Piinks · 2023-04-20T20:25:03Z

packages/flutter/lib/src/widgets/sliver.dart

+  }
+
+  @override
+  Type get debugTypicalAncestorWidgetClass => Widget;


Why is this Widget? Usually this is a bit more specific, can you explain?

SliverCrossAxisGroup has yet to be defined, but I will change it in the SliverCrossAxisGroup PR.

Co-authored-by: Kate Lovett <[email protected]>

Piinks · 2023-04-24T22:50:07Z

packages/flutter/lib/src/rendering/sliver.dart

+  /// If null or zero, the child is inflexible and determines its own size in the cross axis.
+  int? crossAxisFlex;


Have you tried this with the SliverGroup? I think I recall there was an issue with wanting to flex normal slivers along with SliverCross..Expanded. How will the group determine that a normal sliver, say SliverList, should flex if it's flex value is null?

I think this is the only item left here to resolve. :)

Yep I've tried this with SliverGroup and it works well. Essentially SliverGroup's setupParentData method will create children parentData with crossAxisFlex of 1. However, the ParentDataWidgets for the SliverCrossAxisConstrained will set this to 0, for the constrained widgets.

Piinks

Roll Flutter from c9004ff to 66fa4c5 (68 revisions) flutter/flutter@c9004ff...66fa4c5 2023-04-26 [email protected] Remove web compile benchmarks that specify an attached device (flutter/flutter#125559) 2023-04-26 [email protected] Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560) 2023-04-26 [email protected] Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558) 2023-04-26 [email protected] Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555) 2023-04-26 [email protected] Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552) 2023-04-26 [email protected] Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549) 2023-04-26 [email protected] Update prefer_final_parameters comment (flutter/flutter#125465) 2023-04-26 [email protected] Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539) 2023-04-26 [email protected] Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536) 2023-04-26 [email protected] Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533) 2023-04-26 [email protected] Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531) 2023-04-26 [email protected] Add hostonly web compile size benchmarks (flutter/flutter#125518) 2023-04-26 [email protected] Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529) 2023-04-25 [email protected] Handle dollar signs properly when generating localizations (flutter/flutter#125514) 2023-04-25 [email protected] Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516) 2023-04-25 [email protected] Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513) 2023-04-25 [email protected] Adds selected semantics flag to radio button for Apple devices (flutter/flutter#125499) 2023-04-25 [email protected] Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510) 2023-04-25 [email protected] Relabel JSFunction as JSExportedDartFunction (flutter/flutter#125453) 2023-04-25 [email protected] Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504) 2023-04-25 [email protected] iOS TextField spell check style (flutter/flutter#125432) 2023-04-25 [email protected] Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490) 2023-04-25 [email protected] Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485) 2023-04-25 [email protected] Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481) 2023-04-25 [email protected] Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475) 2023-04-25 [email protected] Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472) 2023-04-25 [email protected] Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463) 2023-04-25 [email protected] Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (flutter/flutter#125038) 2023-04-25 [email protected] Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459) 2023-04-25 [email protected] Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458) 2023-04-25 [email protected] Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454) 2023-04-25 [email protected] Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452) 2023-04-24 [email protected] Add Sliders to `macrobenchmarks` (flutter/flutter#125296) 2023-04-24 [email protected] [date_picker] [date_range_picker] add properties to change switch-to icons (flutter/flutter#124881) 2023-04-24 [email protected] Sliver Constrained Cross Axis (flutter/flutter#125239) 2023-04-24 [email protected] tool: Move cdKey to CustomDimensionsEnum (flutter/flutter#125335) 2023-04-24 [email protected] Add `borderRadius` to LinearProgressIndicator (flutter/flutter#123517) 2023-04-24 [email protected] Fix JS types in _test_http_request.dart (flutter/flutter#125220) 2023-04-24 [email protected] Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (flutter/flutter#125204) 2023-04-24 [email protected] Swap some iOS TESTOWNERS (flutter/flutter#125340) 2023-04-24 [email protected] Fix iOS touch drag behavior (flutter/flutter#125169) 2023-04-24 [email protected] Mark module_test_ios flaky (flutter/flutter#125426) 2023-04-24 [email protected] Implement url support for RouteInformation and didPushRouteInformation (flutter/flutter#119968) 2023-04-24 [email protected] [tool,web] Include more info URI on Wasm init failure (flutter/flutter#125312) 2023-04-24 [email protected] Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (flutter/flutter#125343) 2023-04-24 [email protected] Tiny fix doc pointing to incorrect widget confusing the readers (flutter/flutter#125394) ...

thkim1011 added 3 commits April 20, 2023 14:55

Revert "Revert "Sliver Constrained Cross Axis" (flutter#125233)"

3e8c671

This reverts commit 9caabdd.

changes to implementation

ef72886

add a test

e823bce

thkim1011 requested a review from Piinks April 20, 2023 19:13

Piinks reviewed Apr 20, 2023

View reviewed changes

thkim1011 and others added 4 commits April 20, 2023 16:42

Update packages/flutter/lib/src/rendering/sliver.dart

aa7ae83

Co-authored-by: Kate Lovett <[email protected]>

Update packages/flutter/lib/src/rendering/sliver.dart

eb1fd6c

Co-authored-by: Kate Lovett <[email protected]>

address comments

b16792e

Update packages/flutter/lib/src/widgets/sliver.dart

ba50966

Co-authored-by: Kate Lovett <[email protected]>

thkim1011 requested a review from Piinks April 20, 2023 21:13

Piinks reviewed Apr 24, 2023

View reviewed changes

Piinks approved these changes Apr 24, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023

auto-submit bot merged commit 482d1aa into flutter:master Apr 24, 2023

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 932faedce2f8 (93 revisions) flutter/packages#3813

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

7826e5e

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 8cd11e91fb7d (94 revisions) flutter/packages#3815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

295978d

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from c9004ff822cf to 8cd11e91fb7d (47 revisions) flutter/packages#3817

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

4483780

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to b0ae2e81bab5 (66 revisions) flutter/packages#3827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

70b5ae8

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to c9d7bed4216b (67 revisions) flutter/packages#3829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

ff27eb7

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/packages#3830

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)

67d7149

HansMuller mentioned this pull request Apr 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Piinks mentioned this pull request May 2, 2023

Add SliverSizedBox (perhaps SliverConstrainedBox, SliverLimitedBox, etc?) #125797

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sliver Constrained Cross Axis #125239

Sliver Constrained Cross Axis #125239

Uh oh!

thkim1011 commented Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks Apr 20, 2023

Uh oh!

thkim1011 Apr 20, 2023

Uh oh!

Piinks Apr 24, 2023

Uh oh!

Piinks Apr 24, 2023

Uh oh!

thkim1011 Apr 24, 2023

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

		/// If null or zero, the child is inflexible and determines its own size in the cross axis.
		int? crossAxisFlex;

Sliver Constrained Cross Axis #125239

Sliver Constrained Cross Axis #125239

Uh oh!

Conversation

thkim1011 commented Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

thkim1011 Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

thkim1011 Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!