Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade vm_service. #144845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2024
Merged

Upgrade vm_service. #144845

merged 2 commits into from
Mar 9, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Mar 8, 2024 •
edited
Loading

Command:

../../bin/flutter update-packages --cherry-pick-package vm_service --cherry-pick-version 14.1.0

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 8, 2024
@polina-c polina-c changed the title upgrade3 Upgrade vm_service. Mar 8, 2024
@polina-c
Copy link
Contributor Author

polina-c commented Mar 8, 2024

Error:

01:57 +17 ~1 -1: test/integration.shard/test_test.dart: flutter test should run a test when its name matches a regexp when --experimental-faster-testing is set [E]                                    
  Expected: a process with exit code 0 and stdout: "RegExp: pattern=\+\d+: All tests passed! flags="
    Actual: <Instance of 'ProcessResult'>
     Which: Actual exitCode was 1
            Actual stdout:
            [ERROR:flutter/shell/testing/tester_main.cc(671)] Unhandled exception
            Exception: 'file:///b/s/w/ir/x/w/flutter/dev/automated_tests/build/isolate_spawning_tester/root_test_isolate_spawner.dart': error: build/isolate_spawning_tester/root_test_isolate_spawner.dart:70:16: Error: The method 'toNativeUtf8' isn't defined for the class 'String'.
            Try correcting the name to the name of an existing method, or defining a method named 'toNativeUtf8'.
                          .toNativeUtf8()) as void Function(SendPort),
                           ^^^^^^^^^^^^
            Stack trace: #0      _runMain.<anonymous closure> (dart:ui/hooks.dart:301:23)
            #1      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
            #2      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
            
            
            Actual stderr:
            Error: Couldn't resolve the package 'ffi' in 'package:ffi/ffi.dart'.
            build/isolate_spawning_tester/child_test_isolate_spawner.dart:5:8: Error: Not found: 'package:ffi/ffi.dart'
            import 'package:ffi/ffi.dart';
                   ^

@polina-c
Copy link
Contributor Author

polina-c commented Mar 8, 2024

@bkonyi @derekxu16 @a-siva

Upgrade of vm_service for flutter results in ffi issue. Any ideas what can it be?

@derekxu16
Copy link
Contributor

derekxu16 commented Mar 8, 2024 •
edited
Loading

The problem is that flutter update-packages removed the ffi dependency from package:flutter_tools. The context for why the dependency was added is explained here

flutter/packages/flutter_tools/lib/src/test/runner.dart

Lines 268 to 272 in 0a40291

// To compile root_test_isolate_spawner.dart and
// child_test_isolate_spawner.dart successfully, we will need to pass a
// package_config.json to the frontend server that contains the
// union of package:test_core, package:ffi, and all the dependencies of the
// project under test. This function generates such a package_config.json.

and here (#141726 (comment)). I must have added the depedency incorrectly. @christopherfujino, can you please let me know how I can add the ffi dependency in a way such that it doesn't get removed by flutter update-packages? Thanks!

@polina-c
Copy link
Contributor Author

polina-c commented Mar 8, 2024

The problem is that flutter update-packages removed the ffi dependency ...

Added ffi as direct dependency. Let's see if tests pass.

@polina-c polina-c mentioned this pull request Mar 8, 2024
Closed
@polina-c polina-c marked this pull request as ready for review March 8, 2024 22:44
@polina-c polina-c requested a review from derekxu16 March 8, 2024 22:44
@christopherfujino
Copy link
Contributor

Was the issue here that vm_service removed the dependency to package:ffi, and flutter_tools was relying on it being present transitively via vm_service? If so, then I agree, explicitly adding package:ffi as a direct dep is the right way forward.

christopherfujino
christopherfujino approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit a04fe31 into flutter:master Mar 9, 2024
@polina-c polina-c deleted the upgrade3 branch March 9, 2024 01:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
35dd9f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
f1da368
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
b9d2d2b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
87630ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
602325f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
3867647
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
Manual roll Flutter from 7c89ec8 to 3bb2e59 (31 revisions) (#6299)
3eb794b 
Manual roll Flutter from 7c89ec8 to 3bb2e59 (31 revisions)

Manual roll requested by [email protected]

flutter/flutter@7c89ec8...3bb2e59

2024-03-11 [email protected] Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 [email protected] Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 [email protected] Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 [email protected] Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 [email protected] Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 [email protected] Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 [email protected] Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 [email protected] Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 [email protected] Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 [email protected] Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 [email protected] Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 [email protected] Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 [email protected] Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 [email protected] Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 [email protected] Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 [email protected] Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 [email protected] Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 [email protected] Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 [email protected] Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 [email protected] Replace dead links (flutter/flutter#144827)
2024-03-09 [email protected] Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 [email protected] Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 [email protected] Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 [email protected] Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 [email protected] Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 [email protected] Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 [email protected] Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 [email protected] Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 [email protected] Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 [email protected] Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
Roll Flutter from 7c89ec8 to 3bb2e59 (31 revisions) (#6300)
1e46a6a 
flutter/flutter@7c89ec8...3bb2e59

2024-03-11 [email protected] Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923)
2024-03-11 [email protected] Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920)
2024-03-11 [email protected] Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907)
2024-03-10 [email protected] Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858)
2024-03-10 [email protected] Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894)
2024-03-10 [email protected] Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891)
2024-03-09 [email protected] Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889)
2024-03-09 [email protected] Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887)
2024-03-09 [email protected] Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884)
2024-03-09 [email protected] Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876)
2024-03-09 [email protected] Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875)
2024-03-09 [email protected] Fix multiple calls to Slider's onChanged. (flutter/flutter#143680)
2024-03-09 [email protected] Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870)
2024-03-09 [email protected] Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866)
2024-03-09 [email protected] Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865)
2024-03-09 [email protected] Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864)
2024-03-09 [email protected] Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863)
2024-03-09 [email protected] Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862)
2024-03-09 [email protected] Upgrade vm_service. (flutter/flutter#144845)
2024-03-09 [email protected] Replace dead links (flutter/flutter#144827)
2024-03-09 [email protected] Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849)
2024-03-09 [email protected] Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861)
2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855)
2024-03-08 [email protected] Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844)
2024-03-08 [email protected] Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176)
2024-03-08 [email protected] Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839)
2024-03-08 [email protected] Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790)
2024-03-08 [email protected] Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832)
2024-03-08 [email protected] Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677)
2024-03-08 [email protected] Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817)
2024-03-08 [email protected] Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
a04fe31 Upgrade vm_service. (flutter/flutter#144845)
82ae013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekxu16 derekxu16 Awaiting requested review from derekxu16

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polina-c @derekxu16 @christopherfujino