Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve UI-thread animation performance #159288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2024
Merged

Improve UI-thread animation performance #159288

merged 2 commits into from
Dec 7, 2024

Conversation

bernaferrari
Copy link
Contributor

@bernaferrari bernaferrari commented Nov 21, 2024 •
edited
Loading

The following PR (#138481) got split in 2, this is part 2.

We now have the microbenchmarks to compare this change against (and hopefully see improvements).

Close: #146211
Part 1: #153368

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Nov 21, 2024
@bernaferrari bernaferrari force-pushed the part2 branch 2 times, most recently from cbd5f6b to c32e6bd Compare November 21, 2024 19:50
@nate-thegrate nate-thegrate self-requested a review December 5, 2024 21:12
@nate-thegrate
Copy link
Contributor

I took the same benchmark I used for #159757 and ran it against this branch. Much to my chagrin, I only saw a performance improvement of 0.1 ms, i.e. within the margin of error.

But after reading through #138481, it turns out that we had different use cases: I was just checking the ability to send a bunch of notifications whereas @ignatz was repeatedly adding & removing listeners.

So the good news is: this PR vastly improves performance for their use case without making mine any worse!

nate-thegrate
nate-thegrate approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and huge thanks to everyone who was working on #138481!

I just had a couple of tiny nits, which are especially trivial since the new autoformatter will soon take care of whitespace automatically 🙂

@bernaferrari bernaferrari added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 7, 2024
Merged via the queue into flutter:master with commit c1a6c55 Dec 7, 2024
79 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
9cb1879
@bernaferrari bernaferrari deleted the part2 branch December 7, 2024 17:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
5472858
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
bd11eec
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
d460b6e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
e98a74b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
364a812
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
34d7a43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
af529f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
ca154a9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
28c7c56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
49f79c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
ed0695d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
3e320ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
aae7a36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
2cb6bbe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
b2c7457
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
865cf69
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
03d6b5e
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
faac266
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
657b8a4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
90a0825
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
518e8b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
c1a6c55 Improve UI-thread animation performance (flutter/flutter#159288)
897c446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-thegrate nate-thegrate nate-thegrate approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UI-thread animation performance through ObserverList
2 participants
@bernaferrari @nate-thegrate