-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Fix RangeSlider
thumb doesn't align with divisions, thumb padding, and rounded corners
#159792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and rounded corners
@Piinks Hey! You reviewed similar PR for Slider so requested review here. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also LGTM! The google testing failures are okay to me too, they are all typical hairline diffs around sliders as expected from this change.
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
… padding, and rounded corners (flutter/flutter#159792)
Fixes
RangeSlider
thumb's center doesn't align with division's center, thumb padding, and rounded corners don't work as expectedThis makes a similar fix as the one for
Slider
in #149594. This fix is essential to bring updated Material Design forRangeSlider
.Code sample
expand to view the code sample
Before
After
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.