Started pixel aligning hairlines #166351

gaaclarke · 2025-04-01T18:04:46Z

fixes #162378
builds from: #165079
gets rid of the line artifacts in #165689

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2025-04-01T20:07:07Z

The repo code is going through DrawPath, not DrawLine. That's why it's not aligned.

jonahwilliams

LGTM

gaaclarke · 2025-04-01T21:26:21Z

Note to self: This will make it so I can't use DrawPath vs DrawLine as a way to enable/disable antialiasing. That's probably fine now it's in a good state.

auto-submit · 2025-04-01T21:39:15Z

autosubmit label was removed for flutter/flutter/166351, because - The status or check suite Linux_android_emu android_engine_opengles_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-04-01T21:51:34Z

autosubmit label was removed for flutter/flutter/166351, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-04-01T22:28:15Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166351 at sha 0e9908e

gaaclarke · 2025-04-01T22:42:45Z

Goldens are looking real good. There were a handful of hairlines that look much better in the tests.

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542) 2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457) 2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043) 2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332) 2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 [email protected] Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542) 2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 [email protected] Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457) 2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043) 2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332) 2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Started pixel aligning hairlines

571d7f5

github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 1, 2025

This comment was marked as outdated.

Sign in to view

gaaclarke added 4 commits April 1, 2025 13:25

brought in path drawing

6edde99

more cleanup

73f3399

renamed local

aaeeb04

made the rounding math a bit more accurate

0e9908e

gaaclarke marked this pull request as ready for review April 1, 2025 21:17

gaaclarke requested a review from jonahwilliams April 1, 2025 21:18

jonahwilliams approved these changes Apr 1, 2025

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 1, 2025

gaaclarke added this pull request to the merge queue Apr 2, 2025

matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot added this pull request to the merge queue Apr 2, 2025

gaaclarke removed this pull request from the merge queue due to a manual request Apr 2, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

jonahwilliams mentioned this pull request Apr 2, 2025

[Impeller] Pixel snap perfectly horizontal or vertical lines. #165079

Closed

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot added this pull request to the merge queue Apr 2, 2025

Merged via the queue into flutter:master with commit 25f7c15 Apr 2, 2025
177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 275ad8da5b97 (30 revisions) flutter/packages#8987

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

a78c666

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

e6fc997

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 6df932243c12 (31 revisions) flutter/packages#8989

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

ea6b75b

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 3237222b6211 (33 revisions) flutter/packages#8991

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

4f2234c

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 269d544a9b9a (34 revisions) flutter/packages#8993

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

9c5ee25

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 73590fb0d2b7 (35 revisions) flutter/packages#8994

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

d38e316

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to ceec33f16bea (36 revisions) flutter/packages#8995

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

99333b6

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/packages#8996

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

f1765ed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

fd9862a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

25f7c15dd Started pixel aligning hairlines (flutter/flutter#166351)

d4a1889

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Started pixel aligning hairlines #166351

Started pixel aligning hairlines #166351

Uh oh!

gaaclarke commented Apr 1, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

gaaclarke commented Apr 1, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

gaaclarke commented Apr 1, 2025

Uh oh!

auto-submit bot commented Apr 1, 2025

Uh oh!

auto-submit bot commented Apr 1, 2025

Uh oh!

flutter-dashboard bot commented Apr 1, 2025

Uh oh!

gaaclarke commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Started pixel aligning hairlines #166351

Started pixel aligning hairlines #166351

Uh oh!

Conversation

gaaclarke commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

gaaclarke commented Apr 1, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Apr 1, 2025

Uh oh!

auto-submit bot commented Apr 1, 2025

Uh oh!

auto-submit bot commented Apr 1, 2025

Uh oh!

flutter-dashboard bot commented Apr 1, 2025

Uh oh!

gaaclarke commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke commented Apr 1, 2025 •

edited

Loading