Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate ExpansionTileController #166368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 3, 2025
Merged

Deprecate ExpansionTileController #166368

merged 7 commits into from
Apr 3, 2025

Conversation

victorsanni
Copy link
Contributor

Fixes #165511

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: tech-debt Technical debt, code quality, testing, etc. labels Apr 1, 2025
@victorsanni victorsanni marked this pull request as ready for review April 1, 2025 22:14
chunhtai
chunhtai approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test_fixes/material/expansion_tile.dart.expect Outdated
void main() {
// Changes made in https://github.com/flutter/flutter/pull/166368
ExpansibleController();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

MitchellGoodwin
MitchellGoodwin approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MitchellGoodwin
MitchellGoodwin reviewed Apr 1, 2025
View reviewed changes
packages/flutter/lib/fix_data/fix_material/fix_expansion_tile.yaml Outdated
- title: "Migrate to 'ExpansibleController'"
date: 2025-04-01
element:
uris: [ 'material.dart' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably have to add widgets.dart to the uris, so [ 'material.dart', 'widgets.dart' ]

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166368 at sha 2e9b8cc

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 2, 2025
@victorsanni victorsanni added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Apr 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
@jtmcdole jtmcdole removed this pull request from the merge queue due to a manual request Apr 2, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 3, 2025
Merged via the queue into flutter:master with commit e1213e4 Apr 3, 2025
76 of 77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
5cc1b4b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
feb3523
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
1dfe07b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
027751c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
1148260
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
369839b
This was referenced Apr 3, 2025
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
7596703
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
267ac7b 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@victorsanni victorsanni mentioned this pull request Apr 9, 2025
Merged
4 tasks
sfshaza2 pushed a commit to flutter/website that referenced this pull request Apr 9, 2025
@victorsanni
Migration guide for ExpansionTileController deprecation (#11885)
e10dbd9 
Added a migration guide for a deprecation in
flutter/flutter#166368.

## Presubmit checklist

- [ ] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [ ] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [ ] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [ ] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
@Piinks Piinks mentioned this pull request Apr 18, 2025
Open
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
57f42e1 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
a9a898e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
dedac2b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
e1213e486 Deprecate ExpansionTileController (flutter/flutter#166368)
bdd4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate ExpansionTileController in favor of ExpansibleController
4 participants
@victorsanni @chunhtai @MitchellGoodwin @dkwingsmt