Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Full date localizations update #168016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 29, 2025

#168008 must land first. ✅
This is the full update to date localizations, having run:

dart --enable-asserts dev/tools/localization/bin/gen_date_localizations.dart --overwrite

#168008 fixes a crash for ga, this follows with the rest.
There were some customer failures from the full update. Will need to address here.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks marked this pull request as draft April 29, 2025 20:07
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) labels Apr 29, 2025
@Piinks Piinks requested a review from QuncCccccc April 29, 2025 20:08
@Piinks Piinks marked this pull request as ready for review April 30, 2025 18:15
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@@ -425,7 +425,7 @@ Future<void> _pumpBoilerplate(
await tester.pumpWidget(
MaterialApp(
home: Directionality(
textDirection: TextDirection.ltr,
textDirection: textDirection,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch🤣!

@Piinks
Copy link
Contributor Author

Piinks commented May 2, 2025

Bah I think I need to make a new PR to get Google testing to work. I know there are failures, so I need to see the results for a g3fix. I will rebase one more time to see iff Google testing will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants