-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Full date localizations update #168016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Full date localizations update #168016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@@ -425,7 +425,7 @@ Future<void> _pumpBoilerplate( | |||
await tester.pumpWidget( | |||
MaterialApp( | |||
home: Directionality( | |||
textDirection: TextDirection.ltr, | |||
textDirection: textDirection, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch🤣!
Bah I think I need to make a new PR to get Google testing to work. I know there are failures, so I need to see the results for a g3fix. I will rebase one more time to see iff Google testing will work. |
#168008 must land first. ✅
This is the full update to date localizations, having run:
#168008 fixes a crash for
ga
, this follows with the rest.There were some customer failures from the full update. Will need to address here.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.