Remove release_build: "false" which is interpreted as true due to a recipes bug.
#168098
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
approved these changes
Apr 30, 2025
|
thank you! |
|
autosubmit label was removed for flutter/flutter/168098, because - The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
autosubmit label was removed for flutter/flutter/168098, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
May 1, 2025
… a recipes bug. (flutter#168098) Mitigates flutter#168088. The non-existence of `properties: release_build: "true"` is the same thing as `false`. I'll fix the recipe, but this is better for now. /cc @sigmundch for FYI.
Merged
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
auto-submit bot
pushed a commit
that referenced
this pull request
May 1, 2025
…e` due to a recipes bug. (#168147) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #168098 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Works around infrastructure bug that would cause the release build process for release candidates to take longer than expected. ### Workaround: Is there a workaround for this issue? Yes, wait longer. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Already validated on master.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 2, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 2, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 2, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 2, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 2, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 3, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 3, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…ue` due to a recipes bug. (flutter/flutter#168098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #168088.
The non-existence of
properties: release_build: "true"is the same thing asfalse.I'll fix the recipe, but this is better for now.
/cc @sigmundch for FYI.