Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CP-beta]Remove release_build: "false" which is interpreted as true due to a recipes bug. #168147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented May 1, 2025

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#168098

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

N/A

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Works around infrastructure bug that would cause the release build process for release candidates to take longer than expected.

Workaround:

Is there a workaround for this issue?

Yes, wait longer.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Already validated on master.

… a recipes bug. (flutter#168098)

Mitigates flutter#168088.

The non-existence of `properties: release_build: "true"` is the same
thing as `false`.

I'll fix the recipe, but this is better for now.

/cc @sigmundch for FYI.
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label May 1, 2025
@flutteractionsbot
Copy link
Author

@matanlurey please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label May 1, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
Copy link
Contributor

auto-submit bot commented May 1, 2025

autosubmit label was removed for flutter/flutter/168147, because - The status or check suite Mac clangd has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@auto-submit auto-submit bot merged commit 5f0ca4d into flutter:flutter-3.32-candidate.0 May 1, 2025
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants