Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. #168433

matanlurey · 2025-05-07T00:35:41Z

This PR moves project-specific configuration from:

flutter:
  disable-swift-package-manager: true

to:

flutter:
  config:
    enable-swift-package-manager: false

…t-pm: false.

vashworth · 2025-05-07T15:10:44Z

packages/flutter_tools/lib/src/flutter_manifest.dart

-          errors.add(
-            'Expected "$yamlKey" to be a bool, but got $yamlValue (${yamlValue.runtimeType}).',
-          );
-        }


If people still have the old setup in their pubspec, won't it throw an error (see line 617 below)?

Perhaps instead of removing completely, throw a guided error here explaining how to fix

vashworth · 2025-05-07T15:11:16Z

Website docs will also need to be updated: https://docs.flutter.dev/tools/pubspec#disable-swift-package-manager-field

vashworth · 2025-05-07T16:28:24Z

packages/flutter_tools/lib/src/flutter_manifest.dart

-          );
-        }
+        errors.add(
+          // ignore: missing_whitespace_between_adjacent_strings


Is this ignore needed? Seems to me all the string have \n between them

That was a mistake, I thought I hit auto-fix not auto-ignore. Done.

matanlurey · 2025-05-07T16:33:41Z

Website docs will also need to be updated: https://docs.flutter.dev/tools/pubspec#disable-swift-package-manager-field

Done flutter/website#11981.

vashworth

LGTM

…t-...: true`. (flutter/flutter#168433)

Reflects the change made in flutter/flutter#168433. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

…t-...: true`. (flutter/flutter#168433)

flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9230) flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…t-...: true`. (flutter/flutter#168433)

Try moving from manifest disable-swift-pm: true to config enable-swif…

4e8f3fb

…t-pm: false.

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels May 7, 2025

++

0cbc351

matanlurey marked this pull request as ready for review May 7, 2025 00:48

matanlurey requested a review from a team as a code owner May 7, 2025 00:48

matanlurey requested review from loic-sharma and vashworth May 7, 2025 00:48

vashworth reviewed May 7, 2025

View reviewed changes

Add guided error and test.

0fe239d

matanlurey requested a review from vashworth May 7, 2025 16:18

vashworth reviewed May 7, 2025

View reviewed changes

++

7200e80

vashworth approved these changes May 7, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025

auto-submit bot added this pull request to the merge queue May 7, 2025

Merged via the queue into flutter:master with commit 806057b May 7, 2025
150 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025

matanlurey mentioned this pull request May 7, 2025

Add a note about the config section. flutter/website#11981

Merged

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 76747c0ecef6 (17 revisions) flutter/packages#9228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

e9cb216

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

2e39668

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 041bbeb88237 (18 revisions) flutter/packages#9229

Closed

matanlurey added a commit to flutter/website that referenced this pull request May 8, 2025

Add a note about the config section. (#11981)

acca0af

Reflects the change made in flutter/flutter#168433. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

802fbb7

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) flutter/packages#9230

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

1e284a1

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

0cd99f7

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

5ff72b0

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

92a7640

…t-...: true`. (flutter/flutter#168433)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

806057be5 Use config: enable-swift-...: false, remove `disable-swif…

93105db

…t-...: true`. (flutter/flutter#168433)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. #168433

Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. #168433

Uh oh!

matanlurey commented May 7, 2025

Uh oh!

vashworth May 7, 2025 •

edited

Loading

Uh oh!

matanlurey May 7, 2025

Uh oh!

vashworth commented May 7, 2025

Uh oh!

vashworth May 7, 2025

Uh oh!

matanlurey May 7, 2025

Uh oh!

matanlurey commented May 7, 2025

Uh oh!

vashworth left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use config: enable-swift-...: false, remove disable-swift-...: true. #168433

Use config: enable-swift-...: false, remove disable-swift-...: true. #168433

Uh oh!

Conversation

matanlurey commented May 7, 2025

Uh oh!

vashworth May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matanlurey May 7, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth commented May 7, 2025

Uh oh!

vashworth May 7, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey May 7, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey commented May 7, 2025

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. #168433

Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. #168433

vashworth May 7, 2025 •

edited

Loading