-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Data assets #169273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data assets #169273
Conversation
ee5429a
to
0f1cbf5
Compare
packages/flutter_tools/lib/src/build_system/targets/hook_runner_native.dart
Show resolved
Hide resolved
packages/flutter_tools/lib/src/build_system/targets/hook_runner_native.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/build_system/targets/hook_runner_native.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/isolated/data_assets_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
Outdated
Show resolved
Hide resolved
66b064f
to
4b5483b
Compare
I don't know why Google testing is red - seems to be a CI issue? |
d63ce0a
to
4aa6f79
Compare
autosubmit label was removed for flutter/flutter/169273, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Reason for revert: seeing flakes of CI runs for various PRs got errors in the Affected PRs include: #170022, #169995 LUCI log of an error:
|
This reverts commit da95aca.
<!-- start_original_pr_link --> Reverts: #169273 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jason-simmons <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: seeing flakes of `dart_data_asset_test.dart` CI runs for various PRs got errors in the `tool_integration_tests` shards. The errors occurred on multiple platforms (Linux, Mac, and Windows). Affected PRs include: #170022, #169995 LUCI log of an error: https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20t <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: mosuem <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Refiling of #164094, which itself is a rebase of #159675 This PR adds bundling support for the experimental dart data asset feature: Dart packages with hooks can now emit data assets which the flutter tool will bundle. It relies on flutter's existing asset bundling mechanism (e.g. entries in AssetManifest.json, DevFS syncing in reload/restart, ...). The support is added under an experimental flag (similar to the existing native assets experimental flag). Also, kNativeAssets is removed to also bundle data assets on flutter build bundle. The chrome sandbox is disabled as per #165664. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Refiling of #164094, which itself is a rebase of #159675
This PR adds bundling support for the experimental dart data asset feature: Dart packages with hooks can now emit data assets which the flutter tool will bundle.
It relies on flutter's existing asset bundling mechanism (e.g. entries in AssetManifest.json, DevFS syncing in reload/restart, ...).
The support is added under an experimental flag (similar to the existing native assets experimental flag).
Also, kNativeAssets is removed to also bundle data assets on flutter build bundle.
The chrome sandbox is disabled as per #165664.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.