Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Data assets #169273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Data assets #169273

merged 2 commits into from
Jun 4, 2025

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented May 22, 2025

Refiling of #164094, which itself is a rebase of #159675

This PR adds bundling support for the experimental dart data asset feature: Dart packages with hooks can now emit data assets which the flutter tool will bundle.

It relies on flutter's existing asset bundling mechanism (e.g. entries in AssetManifest.json, DevFS syncing in reload/restart, ...).

The support is added under an experimental flag (similar to the existing native assets experimental flag).

Also, kNativeAssets is removed to also bundle data assets on flutter build bundle.

The chrome sandbox is disabled as per #165664.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels May 22, 2025
@mosuem mosuem requested a review from bkonyi May 22, 2025 16:33
@mosuem mosuem marked this pull request as ready for review May 22, 2025 16:33
@mosuem mosuem requested a review from a team as a code owner May 22, 2025 16:33
@mosuem mosuem force-pushed the dataAssets branch 2 times, most recently from ee5429a to 0f1cbf5 Compare May 23, 2025 14:23
@mosuem mosuem force-pushed the dataAssets branch 2 times, most recently from 66b064f to 4b5483b Compare June 2, 2025 06:07
@mosuem
Copy link
Contributor Author

mosuem commented Jun 2, 2025

I don't know why Google testing is red - seems to be a CI issue?

@mosuem mosuem force-pushed the dataAssets branch 4 times, most recently from d63ce0a to 4aa6f79 Compare June 3, 2025 15:56
@mosuem mosuem added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
Copy link
Contributor

auto-submit bot commented Jun 3, 2025

autosubmit label was removed for flutter/flutter/169273, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@mosuem mosuem added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 4, 2025
Merged via the queue into master with commit da95aca Jun 4, 2025
148 checks passed
@jason-simmons
Copy link
Member

Reason for revert: seeing flakes of dart_data_asset_test.dart

CI runs for various PRs got errors in the tool_integration_tests shards. The errors occurred on multiple platforms (Linux, Mac, and Windows).

Affected PRs include: #170022, #169995

LUCI log of an error:
https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20tool_integration_tests_7_9/9858/overview

The subprocess terminated before all the expected transitions had been matched.
The transition that we were hoping to see next but that we never saw was:
    1 NOW WAITING FOR> "...Flutter run key command...", "...VERSION: version1...", "...FOUND "packages/data_asset_example/id1": "content1"....", "...NOT-FOUND "packages/data_asset_example/id2"...." (matched 1 so far)
17:00 +5 -1: test/integration.shard/isolated/dart_data_asset_test.dart: dart data assets flutter run on chrome --debug [E]
  Missed some expected transitions.
  test\integration.shard\transition_test_utils.dart 354:5          runFlutter
  ===== asynchronous gap ===========================
  test\integration.shard\isolated\dart_data_asset_test.dart 93:44  main.<fn>.<fn>

@jason-simmons jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 4, 2025
auto-submit bot pushed a commit that referenced this pull request Jun 4, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 4, 2025
@auto-submit auto-submit bot mentioned this pull request Jun 4, 2025
9 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2025
<!-- start_original_pr_link -->
Reverts: #169273
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: seeing flakes of `dart_data_asset_test.dart`

CI runs for various PRs got errors in the `tool_integration_tests`
shards. The errors occurred on multiple platforms (Linux, Mac, and
Windows).

Affected PRs include: #170022,
#169995

LUCI log of an error:
https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20t
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mosuem
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bkonyi}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Refiling of #164094, which itself is a rebase of #159675

This PR adds bundling support for the experimental dart data asset
feature: Dart packages with hooks can now emit data assets which the
flutter tool will bundle.

It relies on flutter's existing asset bundling mechanism (e.g. entries
in AssetManifest.json, DevFS syncing in reload/restart, ...).

The support is added under an experimental flag (similar to the existing
native assets experimental flag).

Also, kNativeAssets is removed to also bundle data assets on flutter
build bundle.

The chrome sandbox is disabled as per #165664.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants