Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Use consist slashes when generating dep files #169570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
May 28, 2025
Merged

🐛 Use consist slashes when generating dep files #169570

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0951fac
🐛 Use consist slashes when generating dep files
AlexV525 May 28, 2025
1cc4a01
🐛 --
AlexV525 May 28, 2025
9a7e8d4
🐛 ++
AlexV525 May 28, 2025
2cbbd78
🐛 Normalize the path before creating a file object
AlexV525 May 28, 2025
01314dd
🧪 Add test and improve previous
AlexV525 May 28, 2025
25dc0b5
✅ ++
AlexV525 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
🐛 Use consist slashes when generating dep files
  • Loading branch information
@AlexV525
AlexV525 committed May 28, 2025
commit 0951facf1c4e58957b3846a516efe850df6ed4c7
17 changes: 10 additions & 7 deletions packages/flutter_tools/lib/src/build_system/depfile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,19 @@ class DepfileService {
}

void _writeFilesToBuffer(List<File> files, StringBuffer buffer) {
final bool backslash = _fileSystem.path.style.separator == r'\';
for (final File outputFile in files) {
if (_fileSystem.path.style.separator == r'\') {
// backslashes and spaces in a depfile have to be escaped if the
// platform separator is a backslash.
final String path = outputFile.path.replaceAll(r'\', r'\\').replaceAll(r' ', r'\ ');
buffer.write(' $path');
// Escape spaces.
String path = _fileSystem.path.normalize(outputFile.path).replaceAll(r' ', r'\ ');
if (backslash) {
// Convert all path separators to backslashes.
// Backslashes in a depfile have to be escaped if the platform separator is a backslash.
path = path.replaceAll(RegExp(r'[/\\]'), r'\\');
} else {
final String path = outputFile.path.replaceAll(r' ', r'\ ');
buffer.write(' $path');
// Convert all path separators to forward slashes.
path = path.replaceAll(r'\', r'/');
}
buffer.write(' $path');
}
}

Expand Down