Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reland "[native assets] Build dev dependencies in flutter test integration_test" #170686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Jun 16, 2025

Reland #170374

Original PR in first commit. Fixes in subsequent commits:

  • flutter is not on the PATH in the device lab, use _flutterBin (consistent with the rest of the test).
    Fixes flutter not found.
  • flutter test integration_test now does not build assets for the host anymore. flutter test builds assets for the host. The TestCommand is now special-case to check for _isIntegrationTest.
    Fixes clang++ not found. (It's the compiler for Linux, but we are running integration tests on an Android device.)

Tests pass locally with:

$ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android

Note:

@dcharkes dcharkes requested review from vashworth and bkonyi June 16, 2025 18:01
@dcharkes dcharkes requested a review from matanlurey as a code owner June 16, 2025 18:01
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 16, 2025
@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 16, 2025
Merged via the queue into master with commit b5dbfc3 Jun 16, 2025
150 of 151 checks passed
@auto-submit auto-submit bot deleted the fix-integration-test-2 branch June 16, 2025 22:06
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2025
@matanlurey
Copy link
Contributor

reason for revert: Broke Windows_mokey native_assets_android again.

@matanlurey matanlurey added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 16, 2025
auto-submit bot pushed a commit that referenced this pull request Jun 17, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 17, 2025
…est integration_test`" (#170686)" (#170718)

<!-- start_original_pr_link -->
Reverts: #170686
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke [`Windows_mokey
native_assets_android`](https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20native_assets_android/2518/overview)
again.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: dcharkes
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {bkonyi, matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Reland #170374

Original PR in first commit. Fixes in subsequent commits:

* `flutter` is not on the `PATH` in the device lab, use `_flutterBin`
(consistent with the rest of the test).
   Fixes `flutter` not found.
* `flutter test integration_test` now does not build assets for the host
anymore. `flutter test` builds assets for the host. The `TestCommand` is
now special-case to check for `_isIntegrationTest`.
Fixes `clang++` not found. (It's the compiler for Linux, but we are
running integration tests on an Android device.)

Tests pass locally with:

```
$ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android
```

Note:

* The device lab tests are not run on presubmit until
#170682 is addressed.
* The emulator tests are not run at all atm:
#170529.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jun 17, 2025
…ration_test`" (#170728)

Reland #170686.

Closes: #168961.

Original PR in first commit. Fix in subsequent commit:

* Do process invocation of `flutter pub add` in a different way.
   Fixes: `ProcessException: %1 is not a valid Win32 application`

Reproduced locally by changing
dev/devicelab/bin/tasks/native_assets_android.dart to
`DeviceOperatingSystem.windows` and verified the `flutter pub add` call
now succeeds.

(Also, moved the add integration test into the create test project to
avoid having multiple `flutter pub get`s.)

Third time is the charm.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants