-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Reland "[native assets] Build dev dependencies in flutter test integration_test
"
#170686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+132
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Jun 16, 2025
bkonyi
approved these changes
Jun 16, 2025
reason for revert: Broke |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…est integration_test`" (#170686)" (#170718) <!-- start_original_pr_link --> Reverts: #170686 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Broke [`Windows_mokey native_assets_android`](https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20native_assets_android/2518/overview) again. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Reland #170374 Original PR in first commit. Fixes in subsequent commits: * `flutter` is not on the `PATH` in the device lab, use `_flutterBin` (consistent with the rest of the test). Fixes `flutter` not found. * `flutter test integration_test` now does not build assets for the host anymore. `flutter test` builds assets for the host. The `TestCommand` is now special-case to check for `_isIntegrationTest`. Fixes `clang++` not found. (It's the compiler for Linux, but we are running integration tests on an Android device.) Tests pass locally with: ``` $ cd /Users/dacoharkes/src/flutter/flutter/dev/devicelab && dart bin/test_runner.dart test -t native_assets_android ``` Note: * The device lab tests are not run on presubmit until #170682 is addressed. * The emulator tests are not run at all atm: #170529. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…ration_test`" (#170728) Reland #170686. Closes: #168961. Original PR in first commit. Fix in subsequent commit: * Do process invocation of `flutter pub add` in a different way. Fixes: `ProcessException: %1 is not a valid Win32 application` Reproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to `DeviceOperatingSystem.windows` and verified the `flutter pub add` call now succeeds. (Also, moved the add integration test into the create test project to avoid having multiple `flutter pub get`s.) Third time is the charm.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170686)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #170374
Original PR in first commit. Fixes in subsequent commits:
flutter
is not on thePATH
in the device lab, use_flutterBin
(consistent with the rest of the test).Fixes
flutter
not found.flutter test integration_test
now does not build assets for the host anymore.flutter test
builds assets for the host. TheTestCommand
is now special-case to check for_isIntegrationTest
.Fixes
clang++
not found. (It's the compiler for Linux, but we are running integration tests on an Android device.)Tests pass locally with:
Note:
native_assets
tests #170682 is addressed.