Codestin Search App

vashworth · 2026-02-27T17:32:43Z

#182362 landed, but it did not update userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request updates delegate iteration in userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler: to be mutation-safe by using allObjects on the NSPointerArray of delegates. Additionally, it changes multiple calls from [_delegates allObjects] to the idiomatic dot notation _delegates.allObjects for consistency throughout the file.

vashworth · 2026-02-27T17:36:38Z

No tests because logic is already tested in:

flutter/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegateTest.mm

Lines 613 to 643 in 68a7200

    
           - (void)testCanAddDelegateDuringEnumeration { 
        
             FlutterPluginAppLifeCycleDelegate* delegate = [[FlutterPluginAppLifeCycleDelegate alloc] init]; 
        
             MutatingPlugin* mutatingPlugin = [[MutatingPlugin alloc] init]; 
        
             mutatingPlugin.lifecycleDelegate = delegate; 
        
             mutatingPlugin.shouldAdd = YES;  // Add Mode 
        
             [delegate addDelegate:mutatingPlugin]; 
        
             // Validation that [_delegates allObjects] (snapshotting) prevents NSGenericException crash 
        
             // when a plugin adds another plugin during the dispatch loop. 
        
             BOOL result = [delegate application:[UIApplication sharedApplication] 
        
                   didFinishLaunchingWithOptions:@{}]; 
        
             XCTAssertTrue(result); 
        
           } 
        
           - (void)testCanRemoveSelfDuringEnumeration { 
        
             FlutterPluginAppLifeCycleDelegate* delegate = [[FlutterPluginAppLifeCycleDelegate alloc] init]; 
        
             MutatingPlugin* mutatingPlugin = [[MutatingPlugin alloc] init]; 
        
             mutatingPlugin.lifecycleDelegate = delegate; 
        
             mutatingPlugin.shouldAdd = NO;  // Delete Mode 
        
             [delegate addDelegate:mutatingPlugin]; 
        
             // Validation that [_delegates allObjects] (snapshotting) prevents crash 
        
             // when a plugin removes itself via removeDelegate during the dispatch loop. 
        
             BOOL result = [delegate application:[UIApplication sharedApplication] 
        
                   didFinishLaunchingWithOptions:@{}]; 
        
             XCTAssertTrue(result); 
        
           }

auto-submit · 2026-02-27T19:03:13Z

autosubmit label was removed for flutter/flutter/183018, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ic syntax (flutter/flutter#183018)

…lutter#183018) flutter#182362 landed, but it did not update `userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:` Part of flutter#182361. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…lutter#183018) flutter#182362 landed, but it did not update `userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:` Part of flutter#182361. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…ic syntax (flutter/flutter#183018)

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/flutter@1141b2b...46fb721 2026-03-02 [email protected] [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725) 2026-03-02 [email protected] Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120) 2026-03-02 [email protected] [web] Roll Chrome to 145 (flutter/flutter#182860) 2026-03-02 [email protected] Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118) 2026-03-02 [email protected] Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117) 2026-03-02 [email protected] Add information to issue triage page (flutter/flutter#182145) 2026-03-02 [email protected] Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103) 2026-03-02 [email protected] Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100) 2026-03-02 [email protected] Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101) 2026-03-01 [email protected] Update fl_texture_gl.h (flutter/flutter#182999) 2026-03-01 [email protected] Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096) 2026-03-01 [email protected] Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092) 2026-03-01 [email protected] Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971) 2026-03-01 [email protected] Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088) 2026-03-01 [email protected] Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076) 2026-02-28 [email protected] Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064) 2026-02-28 [email protected] Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057) 2026-02-28 [email protected] Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056) 2026-02-28 [email protected] Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051) 2026-02-28 [email protected] [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android. (flutter/flutter#182918) 2026-02-28 [email protected] Add desktop review teams (flutter/flutter#182972) 2026-02-28 [email protected] [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795) 2026-02-28 [email protected] Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032) 2026-02-28 [email protected] [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974) 2026-02-27 [email protected] Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847) 2026-02-27 [email protected] Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025) 2026-02-27 [email protected] Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021) 2026-02-27 [email protected] When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786) 2026-02-27 [email protected] Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018) 2026-02-27 [email protected] Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913) 2026-02-27 [email protected] Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922) 2026-02-27 [email protected] licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965) 2026-02-27 [email protected] Re-add extended attribute removed by SwiftPM (flutter/flutter#183011) 2026-02-27 [email protected] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301) 2026-02-27 [email protected] Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014) 2026-02-27 [email protected] Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692) 2026-02-27 [email protected] chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973) 2026-02-27 [email protected] Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Add missing mutation-safe delegate iteration and use idomatic syntax

4b15b6c

github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Feb 27, 2026

vashworth marked this pull request as ready for review February 27, 2026 17:34

vashworth requested a review from a team as a code owner February 27, 2026 17:34

vashworth requested a review from LongCatIsLooong February 27, 2026 17:35

gemini-code-assist bot reviewed Feb 27, 2026

View reviewed changes

LongCatIsLooong approved these changes Feb 27, 2026

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2026

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2026

auto-submit bot added this pull request to the merge queue Feb 27, 2026

Merged via the queue into flutter:master with commit 0373dbe Feb 27, 2026
185 of 186 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2026

engine-flutter-autoroll mentioned this pull request Feb 28, 2026

Roll Flutter from 1141b2bdce66 to a225be287e31 (23 revisions) flutter/packages#11141

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

6f899dd

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

57cb5ec

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Feb 28, 2026

Roll Flutter from 1141b2bdce66 to a225be287e31 (23 revisions) flutter/packages#11142

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

a743f54

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 1, 2026

Roll Flutter from 1141b2bdce66 to 5515ae85dae3 (24 revisions) flutter/packages#11147

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

d7f8645

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 1, 2026

Roll Flutter from 1141b2bdce66 to abffac30ae6e (25 revisions) flutter/packages#11148

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

bf11252

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to e78520497800 (33 revisions) flutter/packages#11156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

aabd762

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 434491ab43cf (34 revisions) flutter/packages#11157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

c9ad01c

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to ce6e34771ee0 (35 revisions) flutter/packages#11158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

e32f84b

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 63d4a81ce878 (36 revisions) flutter/packages#11159

Closed

vashworth mentioned this pull request Mar 2, 2026

[CP-stable] Update lifecycle event loops to be mutation-safe #183125

Open

5 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

e122c61

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 1e52e0cf8b20 (37 revisions) flutter/packages#11160

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

0373dbee2 Add missing mutation-safe delegate iteration and use idomat…

a60de06

…ic syntax (flutter/flutter#183018)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/packages#11162

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing mutation-safe delegate iteration and use idomatic syntax#183018

Add missing mutation-safe delegate iteration and use idomatic syntax#183018
auto-submit[bot] merged 1 commit intoflutter:masterfrom
vashworth:missing_safe_delegate_iteration

vashworth commented Feb 27, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

vashworth commented Feb 27, 2026

Uh oh!

auto-submit bot commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vashworth commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

vashworth commented Feb 27, 2026

Uh oh!

auto-submit bot commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vashworth commented Feb 27, 2026 •

edited

Loading