-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Default locales test for flutter tester. Roll engine 162b2e98c03..7be0217d67969 #23596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moving the default locales into flutter_tester startup instead of the dart:ui code. |
@@ -675,4 +673,28 @@ void main() { | |||
expect(find.text('da_DA TextDirection.rtl'), findsOneWidget); | |||
}); | |||
|
|||
// We provide <Locale>[Locale('en', 'US'), Locale('zh', 'CN')] as ui.window.locales | |||
// for platforms without locale passing support so that the behavior of tests | |||
// match that of production environments. Here, we test the default locales. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment seems out of date
f07f619
to
f1f82da
Compare
f1f82da
to
5afd032
Compare
Engine Roll: |
…flutter#23596) 162b2e9..7be0217 7be0217 Roll back _countryCode assert - breaking change (flutter#6693) 91a019c Fix popSystemNavigator (flutter#6691) 2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (flutter#6518) 58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (flutter#6690) 3b17cfb Flutter tester default locales (flutter#6689) 96bbd2b Roll buildroot to 11a934e (flutter#6687) 0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (flutter#6688) cc686d7 Don't populate the external view embedder in PaintContext. (flutter#6686) ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (flutter#6685) c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (flutter#6684) 7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (flutter#6683) 3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (flutter#6682) 2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (flutter#6681) a1d7cad Fix inconsistent include syntax (flutter#6680) 236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter#6679) c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter#6678) ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter#6677) 505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter#6674) 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter#6672) f797004 Attach and position embedded UIVIews (flutter#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter#6603) 2bfb893 iOS Embedding Refactor (flutter#6447)
Tests for the change described in flutter/engine#6673
Requires a manual engine roll.