Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better progress #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2016
Merged

Better progress #6677

merged 6 commits into from
Nov 3, 2016

Conversation

devoncarew
Copy link
Member

  • in Status.stop(), make showElapsedTime default to true; every call site was passing in true
  • fix an issue with the logger ms output, which would leave a dash after short ms times
  • make the output for reload and restart consistent; they both show one progres message for the full duration of the operation, and output a single message upon completion

sample output:

Syncing files to device...                          2050ms

Performing hot reload...                            717ms
Reloaded 391 of 441 libraries.

Performing hot reload...                            144ms
Reloaded 0 of 441 libraries.

Performing full restart...                          859ms
Restart complete.

Application finished.

@devoncarew
Copy link
Member Author

@danrubel @johnmccutchan @Hixie

danrubel
danrubel approved these changes Nov 3, 2016
View reviewed changes
packages/flutter_tools/lib/src/hot.dart
} else {
// upper-case 'R'.
await _restartFromSources();
await restart(fullRestart: true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collapse if statement into this ?
await restart(fullRestart: code == 'R');

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@johnmccutchan
Copy link
Contributor

This needs a merge but LGTM

@devoncarew
Copy link
Member Author

Updated and merged.

johnmccutchan
johnmccutchan approved these changes Nov 3, 2016
View reviewed changes
Copy link
Contributor

@johnmccutchan johnmccutchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

packages/flutter_tools/lib/src/hot.dart
if (result.isOk)
printStatus("${result.message}.");
return result;
} catch (error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a finally and rethrow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I updated this to use rethrow; I'm sticking with catch instead of finally since I want a little more control of when stop() is called.

@devoncarew devoncarew merged commit fcfb2a5 into flutter:master Nov 3, 2016
@gspencergoog gspencergoog mentioned this pull request Jul 10, 2018
Merged
@GaryQian GaryQian mentioned this pull request Oct 30, 2018
Merged
GaryQian added a commit that referenced this pull request Oct 30, 2018
@GaryQian
Default locales test for flutter tester. Roll engine 162b2e9..7be0217 (…
ec5719a 
…#23596)

162b2e9..7be0217
7be0217 Roll back _countryCode assert - breaking change (#6693)
91a019c Fix popSystemNavigator (#6691)
2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (#6518)
58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690)
3b17cfb Flutter tester default locales (#6689)
96bbd2b Roll buildroot to 11a934e (#6687)
0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688)
cc686d7 Don't populate the external view embedder in PaintContext. (#6686)
ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685)
c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684)
7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683)
3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682)
2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681)
a1d7cad Fix inconsistent include syntax (#6680)
236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679)
c4f5061 Roll buildroot to pick up Mac toolchain updates. (#6678)
ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (#6677)
505d2a9 Roll buildroot to pick up updates to custom toolchains. (#6674)
6c2a0b3 Undefine ERROR in platform_view_layer.cc (#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (#6672)
f797004 Attach and position embedded UIVIews (#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (#6603)
2bfb893 iOS Embedding Refactor (#6447)
Xavjer pushed a commit to Xavjer/flutter that referenced this pull request Nov 1, 2018
@GaryQian @Xavjer
Default locales test for flutter tester. Roll engine 162b2e9..7be0217 (…
7058513 
…flutter#23596)

162b2e9..7be0217
7be0217 Roll back _countryCode assert - breaking change (flutter#6693)
91a019c Fix popSystemNavigator (flutter#6691)
2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (flutter#6518)
58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (flutter#6690)
3b17cfb Flutter tester default locales (flutter#6689)
96bbd2b Roll buildroot to 11a934e (flutter#6687)
0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (flutter#6688)
cc686d7 Don't populate the external view embedder in PaintContext. (flutter#6686)
ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (flutter#6685)
c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (flutter#6684)
7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (flutter#6683)
3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (flutter#6682)
2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (flutter#6681)
a1d7cad Fix inconsistent include syntax (flutter#6680)
236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter#6679)
c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter#6678)
ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter#6677)
505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter#6674)
6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter#6672)
f797004 Attach and position embedded UIVIews (flutter#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (flutter#6603)
2bfb893 iOS Embedding Refactor (flutter#6447)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

@danrubel danrubel danrubel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devoncarew @johnmccutchan @danrubel