Reject unaccepted pointers in Drag recognizer#75943
Merged
Merged
Conversation
Member
Author
dkwingsmt
approved these changes
Feb 13, 2021
dkwingsmt
left a comment
Contributor
There was a problem hiding this comment.
LGTM except for a small comment
| } | ||
| } | ||
|
|
||
| final List<int> _acceptedActivePointers = <int>[]; |
Contributor
There was a problem hiding this comment.
According to the use cases, shouldn't Set be a better container here?
xu-baolin
reviewed
Feb 15, 2021
| localPosition: _initialPosition.local, | ||
| ); | ||
| invokeCallback<void>('onDown', () => onDown!(details)); | ||
| } |
Member
There was a problem hiding this comment.
👍
_checkStart and _checkUpdate also can be optimized.
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Mar 10, 2021
18 tasks
christopherfujino
added a commit
that referenced
this pull request
Mar 11, 2021
* Reject unaccepted pointers in Drag recognizer (#75943) * Delete unzipped FlutterMacOS.framework before replacing artifact (#77316) * Fix missing root Scaffold check in ScaffoldMessenger (#77410) * Roll engine cherrypicks Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Kate Lovett <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75061.
#75061 (comment) contains a detailed description of what the problem was that's fixed by this PR.