Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flutter_releases] Flutter 2.0.2 Stable Framework Cherrypicks#77850

Merged
christopherfujino merged 4 commits into
flutter:flutter-1.26-candidate.17from
chris-forks:cherrypicks-flutter-1.26-candidate.17
Mar 11, 2021
Merged

[flutter_releases] Flutter 2.0.2 Stable Framework Cherrypicks#77850
christopherfujino merged 4 commits into
flutter:flutter-1.26-candidate.17from
chris-forks:cherrypicks-flutter-1.26-candidate.17

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Scheduled Cherrypicks

Known Failures

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 10, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 March 10, 2021 21:21
@flutter-dashboard

flutter-dashboard Bot commented Mar 10, 2021

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla

google-cla Bot commented Mar 10, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Mar 10, 2021
@christopherfujino

christopherfujino commented Mar 10, 2021

Copy link
Copy Markdown
Contributor Author

I manually overrode the CLAbot because all authors have signed the CLA.

jmagman
jmagman approved these changes Mar 11, 2021
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#77316 LGTM. #77173 will also go away once the engine version gets revved.

goderbauer
goderbauer approved these changes Mar 11, 2021
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Mar 11, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🌸

@christopherfujino christopherfujino merged commit 8962f6d into flutter:flutter-1.26-candidate.17 Mar 11, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch March 12, 2021 18:49
@jmagman

jmagman commented Mar 12, 2021

Copy link
Copy Markdown
Member

The failing tests passed for me locally:

Task result:
{
  "success": true,
  "data": {
    "engineEnterTimestampMicros": 258498883041,
    "timeToFrameworkInitMicros": 175697,
    "timeToFirstFrameRasterizedMicros": 1220647,
    "timeToFirstFrameMicros": 251485,
    "timeAfterFrameworkInitMicros": 75788
  },
  "detailFiles": [],
  "benchmarkScoreKeys": [
    "timeToFirstFrameMicros",
    "timeToFirstFrameRasterizedMicros"
  ]
}


════════════╡ ••• Finished task "complex_layout_ios__start_up" ••• ╞════════════

Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": []
}


═════════╡ ••• Finished task "platform_channel_sample_test_swift" ••• ╞═════════

Task result:
{
  "success": true,
  "data": {
    "average_frame_build_time_millis": 1.226,
    "90th_percentile_frame_build_time_millis": 1.907,
    "99th_percentile_frame_build_time_millis": 11.696,
    "worst_frame_build_time_millis": 31.042,
    "missed_frame_build_budget_count": 6,
    "average_frame_rasterizer_time_millis": 5.026,
    "90th_percentile_frame_rasterizer_time_millis": 16.352,
    "99th_percentile_frame_rasterizer_time_millis": 57.886,
    "worst_frame_rasterizer_time_millis": 181.151,
    "missed_frame_rasterizer_budget_count": 125,
    "frame_count": 952,
    "frame_build_times": [
...
    ]
  },
  "detailFiles": [],
  "benchmarkScoreKeys": [
    "average_frame_build_time_millis",
    "worst_frame_build_time_millis",
    "90th_percentile_frame_build_time_millis",
    "99th_percentile_frame_build_time_millis",
    "average_frame_rasterizer_time_millis",
    "worst_frame_rasterizer_time_millis",
    "90th_percentile_frame_rasterizer_time_millis",
    "99th_percentile_frame_rasterizer_time_millis"
  ]
}


══════╡ ••• Finished task "flutter_gallery__transition_perf_e2e_ios" ••• ╞══════

Task result:
{
  "success": true,
  "data": {
    "engineEnterTimestampMicros": 259571406885,
    "timeToFrameworkInitMicros": 191307,
    "timeToFirstFrameRasterizedMicros": 1456516,
    "timeToFirstFrameMicros": 302828,
    "timeAfterFrameworkInitMicros": 111521
  },
  "detailFiles": [],
  "benchmarkScoreKeys": [
    "timeToFirstFrameMicros",
    "timeToFirstFrameRasterizedMicros"
  ]
}


═══════════╡ ••• Finished task "flutter_gallery_ios__start_up" ••• ╞════════════

maged200 added a commit to maged200/flutter that referenced this pull request Feb 15, 2022
@maged200
Revert "[flutter_releases] Flutter 2.0.2 Stable Framework Cherrypicks (…
59e6802 
…flutter#77850)"

This reverts commit 8962f6d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@kf6gpe kf6gpe kf6gpe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christopherfujino @jmagman @goderbauer @kf6gpe @Piinks