Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[flutter_releases] Flutter 2.0.2 Stable Engine Cherrypicks#24928

Merged
christopherfujino merged 4 commits into
flutter-team-archive:flutter-1.26-candidate.17from
christopherfujino:cherrypicks-flutter-1.26-candidate.17
Mar 10, 2021
Merged

[flutter_releases] Flutter 2.0.2 Stable Engine Cherrypicks#24928
christopherfujino merged 4 commits into
flutter-team-archive:flutter-1.26-candidate.17from
christopherfujino:cherrypicks-flutter-1.26-candidate.17

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Scheduled Cherrypicks

  • Dart SDK 2.12.1
  • [web] Canvas Kit issue when using dart:ui/Path.from - BindingError: Tried to invoke ctor of Path with invalid number of parameters (1) - expected (0) parameters instead! #75473
  • Multiple Flutter Engine: destroy flutter engine making live flutter stop response user interaction #76597

Known Failures

@flutter-dashboard

flutter-dashboard Bot commented Mar 10, 2021

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla google-cla Bot added the cla: yes label Mar 10, 2021
kf6gpe
kf6gpe approved these changes Mar 10, 2021
View reviewed changes

@kf6gpe kf6gpe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need a separate eng LGTM?

@christopherfujino

christopherfujino commented Mar 10, 2021

Copy link
Copy Markdown
Contributor Author

LGTM. Do we need a separate eng LGTM?

Yeah, I try to have the authors do a sanity check.

@gaaclarke

gaaclarke commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

my patch looks good

@christopherfujino christopherfujino mentioned this pull request Mar 10, 2021
Merged
18 tasks
@christopherfujino

christopherfujino commented Mar 10, 2021

Copy link
Copy Markdown
Contributor Author

Linux & Mac Web Engine are known failures (documented in description), luci-engine is irrelevant, and cirrus build_and_test_linux_unopt_debug failed on a timeout. I triggered a retry, but I will merge this now to keep the release rolling (the equivalent LUCI build is green).

@christopherfujino christopherfujino merged commit 5d8bf81 into flutter-team-archive:flutter-1.26-candidate.17 Mar 10, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch March 10, 2021 22:33
@christopherfujino

christopherfujino commented Mar 11, 2021

Copy link
Copy Markdown
Contributor Author

Ran into flutter/flutter#77659 post-submit for Windows Host Engine.

@vanlooverenkoen vanlooverenkoen mentioned this pull request Mar 30, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

1 more reviewer

@kf6gpe kf6gpe kf6gpe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherfujino @gaaclarke @kf6gpe @yjbanov