ChipThemeData is now conventional #93452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86cb394 to
d2eae52
Compare
gspencergoog
requested changes
Nov 15, 2021
1742ee1 to
c1ed67e
Compare
42 tasks
HansMuller
pushed a commit
that referenced
this pull request
Nov 17, 2021
This reverts commit 8612f80.
WizzXu
pushed a commit
to WizzXu/flutter
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChipThemeData is now conventional: all of its properties are default null and they define overrides of the defaults defined by the Chip widgets. Default overrides in priority order are (as usual):
All of the ChipThemeData constructor parameters and properties are now nullable. Other than that and the change to the default value of
ThemeData.chipTheme, this change is intended to be backwards compatible.Addresses the "theme normalization" sub project within #91772