[flutter_markdown] Added sizedImageBuilder to Markdown widget #6739

M97Chahboun · 2024-05-15T16:14:24Z

Adds sizedImageBuilder to Markdown widget.

Pre-launch Checklist

domesticmouse

I'm curious how image height and width are parsed from the markdown.

M97Chahboun · 2024-05-18T20:14:13Z

@domesticmouse
If you means how markdown parse the h & w of image
check this line
parsed by get height and width from this format imageLink#200x200

domesticmouse · 2024-05-19T01:13:01Z

Please add a test that covers width x height from markdown to final usage to prevent future breakage

stuartmorgan-g · 2024-06-04T19:55:44Z

The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]

This was not done; please don't check boxes without completing the steps they describe.

All existing and new tests are passing.

CI indicates that the new test is not passing, which will need to be resolved before this can be reviewed.

packages/flutter_markdown/test/image_test.dart

M97Chahboun · 2024-06-05T08:44:11Z

I run image tests before any changes and I get :

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown while running async test code:
Golden "assets/images/golden/image_test/resource_asset_logo.png": Pixel test failed, 0.00% diff
detected.
Failure feedback can be found at
/Users/user/Development/packages/packages/flutter_markdown/test/failures

When the exception was thrown, this was the stack:
#0      LocalFileComparator.compare (package:flutter_test/src/_goldens_io.dart:106:5)
<asynchronous suspension>
#1      MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from dart:async)

The exception was caught asynchronously.
════════════════════════════════════════════

Any suggestion please

stuartmorgan-g · 2024-07-09T19:28:35Z

Tiny changes in golden files are normal if you are on a different host OS than the baseline (which is usually Linux). The issue on CI though is that you've dramatically changed an existing golden test, but haven't changed the expected output.

Please make a new test instead of changing that one, and set a new golden for it.

stuartmorgan-g · 2024-08-06T19:57:38Z

From triage: @M97Chahboun Are you planning on updating the tests per the comments above?

M97Chahboun · 2024-09-03T16:14:58Z

@stuartmorgan I don't have any idea about golden test, but I will try to implement it ASAP

stuartmorgan-g · 2024-10-01T19:55:57Z

Marking as a draft pending new, passing tests that can be reviewed.

stuartmorgan-g · 2024-12-03T20:47:50Z

Since this is marked as a draft and hasn't been updated in several months, I’m going to close it so that our PR queue reflects active PRs. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

packages/flutter_markdown/lib/src/builder.dart

packages/flutter_markdown/lib/src/widget.dart

stuartmorgan-g

LGTM

M97Chahboun · 2025-04-01T17:32:17Z

Thank you for your reviews and patient

…et (flutter/packages#6739)

flutter/packages@125c117...07496eb 2025-04-02 [email protected] [multicast_dns] MDnsClient::listen supports onError callback (flutter/packages#8888) 2025-04-02 [email protected] Upgrade tests to use Xcode 16 and iOS 18 (flutter/packages#8968) 2025-04-01 [email protected] Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960) 2025-04-01 [email protected] Drop deprecated HTML head meta tags (flutter/packages#8970) 2025-04-01 [email protected] Adjust PR checklist formatter discussion (flutter/packages#8924) 2025-04-01 [email protected] Update CODEOWNERS username (flutter/packages#8933) 2025-04-01 [email protected] [flutter_markdown] Added sizedImageBuilder to Markdown widget (flutter/packages#6739) 2025-04-01 [email protected] [google_maps_flutter] Skip impl copy of iOS tests (flutter/packages#8975) 2025-04-01 [email protected] [google_maps_flutter] Skip more hanging iOS tests (flutter/packages#8967) 2025-04-01 [email protected] [url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. (flutter/packages#8582) 2025-04-01 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 2 (flutter/packages#8892) 2025-03-31 [email protected] [webview_flutter] Skip flaky legacy tests on iOS (flutter/packages#8911) 2025-03-31 [email protected] [camera_android] Don't override default fps range when not recording (flutter/packages#8891) 2025-03-31 [email protected] [google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry (flutter/packages#8754) 2025-03-31 [email protected] [extension_gsi] Support the latest version of googleapis_auth (flutter/packages#8931) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8955) 2025-03-31 [email protected] [webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel (flutter/packages#8776) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#8946) 2025-03-31 [email protected] [interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in release mode (flutter/packages#8918) 2025-03-31 [email protected] [google_maps_flutter] Skip test that hangs iOS CI (flutter/packages#8958) 2025-03-28 [email protected] Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter/packages#8922) 2025-03-28 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 3 (flutter/packages#8912) 2025-03-27 [email protected] Use a more deterministic way of waiting for ad widgets to be ready. (flutter/packages#8920) 2025-03-27 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 1 (flutter/packages#8890) 2025-03-27 [email protected] [pigeon] correct usage of extended generics in generator methods (flutter/packages#8910) 2025-03-27 [email protected] [video_player] Fix layout issue caused by `Transform.rotate` not affecting space calculation. (flutter/packages#8685) 2025-03-27 [email protected] [shared_preferences] Fix a late initialized error with the example app (flutter/packages#8540) 2025-03-26 [email protected] [various] Disable sandbox in Chrome dart tests (flutter/packages#8909) 2025-03-25 [email protected] [tool] Move changed file detection to base command class (flutter/packages#8730) 2025-03-25 [email protected] [Camera] Add lens type information (iOS) (flutter/packages#8723) 2025-03-25 [email protected] [pigeon] kotlin equality methods (flutter/packages#8887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Maurice Parrish <[email protected]>

…et (flutter/packages#6739)

Added height and width to image builder

22180cc

M97Chahboun requested a review from domesticmouse as a code owner May 15, 2024 16:14

github-actions bot added the p: flutter_markdown label May 15, 2024

M97Chahboun added 2 commits May 15, 2024 17:41

Updated CHANGELOG file

c8b90a9

format tests

025bf8f

domesticmouse reviewed May 18, 2024

View reviewed changes

Update pubspec.yaml

ce61fb5

M97Chahboun requested a review from domesticmouse May 18, 2024 20:19

Merge branch 'main' into main

a79a517

M97Chahboun and others added 3 commits May 19, 2024 15:42

Adds image builder height and width tests

d8192d1

Added size to precacheImage tests

2ef0b8a

Merge branch 'main' into main

af07d08

M97Chahboun changed the title ~~Added height and width to image builder~~ [flutter_markdown] Added height and width to image builder Jun 4, 2024

domesticmouse reviewed Jun 5, 2024

View reviewed changes

packages/flutter_markdown/test/image_test.dart Outdated Show resolved Hide resolved

Removed unnecessary size for precacheImage test method

efb8038

domesticmouse approved these changes Jul 11, 2024

View reviewed changes

stuartmorgan-g requested a review from tarrinneal July 23, 2024 19:51

domesticmouse approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'main' into main

a928995

stuartmorgan-g marked this pull request as draft October 1, 2024 19:55

stuartmorgan-g closed this Dec 3, 2024

M97Chahboun added 2 commits February 18, 2025 22:16

format codes

99d08a9

removed license comment

4f02de0

stuartmorgan-g requested changes Mar 7, 2025

View reviewed changes

packages/flutter_markdown/lib/src/builder.dart Outdated Show resolved Hide resolved

packages/flutter_markdown/lib/src/builder.dart Outdated Show resolved Hide resolved

packages/flutter_markdown/lib/src/widget.dart Outdated Show resolved Hide resolved

M97Chahboun added 2 commits March 8, 2025 23:17

Improves docs

c8acdbd

format code & mark imageBuilder as Deprecated

698f74c

tarrinneal requested a review from stuartmorgan-g March 17, 2025 20:56

stuartmorgan-g approved these changes Apr 1, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2025

auto-submit bot merged commit bba066f into flutter:main Apr 1, 2025
82 checks passed

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to bba066f89dd4 (25 revisions) flutter/flutter#166349

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

16c1575

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to 28676de193f2 (26 revisions) flutter/flutter#166352

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

2210ec2

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to eb8cb324582e (27 revisions) flutter/flutter#166356

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

a23fb41

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 84ef201205ea (29 revisions) flutter/flutter#166435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

e6ac142

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 5cee1525909d (30 revisions) flutter/flutter#166456

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

b85a35c

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166457

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

d482a95

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166469

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

2b3b519

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166472

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

d5fb629

…et (flutter/packages#6739)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025

bba066f89 [flutter_markdown] Added sizedImageBuilder to Markdown widg…

7d9fdaf

…et (flutter/packages#6739)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166534

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[flutter_markdown] Added sizedImageBuilder to Markdown widget #6739

[flutter_markdown] Added sizedImageBuilder to Markdown widget #6739

Uh oh!

M97Chahboun commented May 15, 2024 •

edited

Loading

Uh oh!

domesticmouse left a comment

Uh oh!

M97Chahboun commented May 18, 2024 •

edited

Loading

Uh oh!

domesticmouse commented May 19, 2024

Uh oh!

stuartmorgan-g commented Jun 4, 2024

Uh oh!

Uh oh!

M97Chahboun commented Jun 5, 2024 •

edited

Loading

Uh oh!

stuartmorgan-g commented Jul 9, 2024

Uh oh!

stuartmorgan-g commented Aug 6, 2024

Uh oh!

M97Chahboun commented Sep 3, 2024 •

edited

Loading

Uh oh!

stuartmorgan-g commented Oct 1, 2024

Uh oh!

stuartmorgan-g commented Dec 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

M97Chahboun commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

[flutter_markdown] Added sizedImageBuilder to Markdown widget #6739

[flutter_markdown] Added sizedImageBuilder to Markdown widget #6739

Uh oh!

Conversation

M97Chahboun commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

domesticmouse left a comment

Choose a reason for hiding this comment

Uh oh!

M97Chahboun commented May 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domesticmouse commented May 19, 2024

Uh oh!

stuartmorgan-g commented Jun 4, 2024

Uh oh!

Uh oh!

M97Chahboun commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Jul 9, 2024

Uh oh!

stuartmorgan-g commented Aug 6, 2024

Uh oh!

M97Chahboun commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Oct 1, 2024

Uh oh!

stuartmorgan-g commented Dec 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

M97Chahboun commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

M97Chahboun commented May 15, 2024 •

edited

Loading

M97Chahboun commented May 18, 2024 •

edited

Loading

M97Chahboun commented Jun 5, 2024 •

edited

Loading

M97Chahboun commented Sep 3, 2024 •

edited

Loading