[multicast_dns] MDnsClient::listen supports onError callback #8888

alexander-irion · 2025-03-18T19:32:18Z

MDnsClient::Listen now supports an optional onError callback function,
called in case of a stream error. If omitted any errors on the stream
are considered unhandled, and will be passed to the current [Zone]'s
error handler. By default unhandled async errors are treated as if they
were uncaught top-level errors.

This fixes an unhandled exception occuring (tested on Android), when the
network is disconnected.

Fixes flutter/flutter#165482

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

How can a test be added? It would need to disconnect the device from WLAN beforehand.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

flutter-dashboard · 2025-03-18T19:32:21Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

google-cla · 2025-03-18T19:32:22Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

stuartmorgan-g · 2025-03-18T20:00:31Z

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

alexander-irion · 2025-03-19T10:21:35Z

@stuartmorgan : How can a test be added? It would need to disconnect the device from WLAN beforehand.

alexander-irion · 2025-03-20T08:53:53Z

@vashworth: Beside a missing test, would the change make sense for you?

…#8888) MDnsClient::Listen now supports an optional onError callback function, called in case of a stream error. If omitted any errors on the stream are considered unhandled, and will be passed to the current [Zone]'s error handler. By default unhandled async errors are treated as if they were uncaught top-level errors. This fixes an unhandled exception occuring (tested on Android), when the network is disconnected. Issue: flutter/flutter#165482

vashworth

Thanks for adding this! This makes sense to me.

alexander-irion · 2025-03-25T08:39:19Z

@vashworth: Hi, what's missing for a merge?

vashworth · 2025-03-28T18:09:37Z

@vashworth: Hi, what's missing for a merge?

Needs 2 approvals.

@stuartmorgan friendly ping.

stuartmorgan-g · 2025-04-01T17:36:42Z

packages/multicast_dns/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.2+9


Per semver, adding new public API is a minor version change, so this should be 0.3.3.

stuartmorgan-g · 2025-04-01T17:38:15Z

packages/multicast_dns/lib/multicast_dns.dart

@@ -84,13 +84,20 @@ class MDnsClient {
  /// for the mDNS query. If not provided, defaults to either `224.0.0.251` or
  /// or `FF02::FB`.
  ///
+  /// The [onError] function allows to provide a callback function, called in


Comments don't need to explain basic language mechanics, like that an argument allows providing something. This first sentence can just say "If provided, [onError] will be called in case of a stream error."

stuartmorgan-g · 2025-04-01T17:39:09Z

packages/multicast_dns/lib/multicast_dns.dart

+  /// case of a stream error. If omitted any errors on the stream are considered
+  /// unhandled, and will be passed to the current [Zone]'s error handler. By
+  /// default unhandled async errors are treated as if they were uncaught top-level
+  /// errors.


This last sentence should be removed, as this is not something that this package or method controls.

stuartmorgan-g · 2025-04-01T17:39:24Z

packages/multicast_dns/pubspec.yaml

@@ -2,7 +2,7 @@ name: multicast_dns
 description: Dart package for performing mDNS queries (e.g. Bonjour, Avahi).
 repository: https://github.com/flutter/packages/tree/main/packages/multicast_dns
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+multicast_dns%22
-version: 0.3.2+8
+version: 0.3.2+9


- Change version to 0.3.3 - Adapt comment about new parameter

stuartmorgan-g

LGTM!

flutter/packages#8888)

flutter/packages@125c117...07496eb 2025-04-02 [email protected] [multicast_dns] MDnsClient::listen supports onError callback (flutter/packages#8888) 2025-04-02 [email protected] Upgrade tests to use Xcode 16 and iOS 18 (flutter/packages#8968) 2025-04-01 [email protected] Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960) 2025-04-01 [email protected] Drop deprecated HTML head meta tags (flutter/packages#8970) 2025-04-01 [email protected] Adjust PR checklist formatter discussion (flutter/packages#8924) 2025-04-01 [email protected] Update CODEOWNERS username (flutter/packages#8933) 2025-04-01 [email protected] [flutter_markdown] Added sizedImageBuilder to Markdown widget (flutter/packages#6739) 2025-04-01 [email protected] [google_maps_flutter] Skip impl copy of iOS tests (flutter/packages#8975) 2025-04-01 [email protected] [google_maps_flutter] Skip more hanging iOS tests (flutter/packages#8967) 2025-04-01 [email protected] [url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. (flutter/packages#8582) 2025-04-01 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 2 (flutter/packages#8892) 2025-03-31 [email protected] [webview_flutter] Skip flaky legacy tests on iOS (flutter/packages#8911) 2025-03-31 [email protected] [camera_android] Don't override default fps range when not recording (flutter/packages#8891) 2025-03-31 [email protected] [google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry (flutter/packages#8754) 2025-03-31 [email protected] [extension_gsi] Support the latest version of googleapis_auth (flutter/packages#8931) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8955) 2025-03-31 [email protected] [webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel (flutter/packages#8776) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#8946) 2025-03-31 [email protected] [interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in release mode (flutter/packages#8918) 2025-03-31 [email protected] [google_maps_flutter] Skip test that hangs iOS CI (flutter/packages#8958) 2025-03-28 [email protected] Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter/packages#8922) 2025-03-28 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 3 (flutter/packages#8912) 2025-03-27 [email protected] Use a more deterministic way of waiting for ad widgets to be ready. (flutter/packages#8920) 2025-03-27 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 1 (flutter/packages#8890) 2025-03-27 [email protected] [pigeon] correct usage of extended generics in generator methods (flutter/packages#8910) 2025-03-27 [email protected] [video_player] Fix layout issue caused by `Transform.rotate` not affecting space calculation. (flutter/packages#8685) 2025-03-27 [email protected] [shared_preferences] Fix a late initialized error with the example app (flutter/packages#8540) 2025-03-26 [email protected] [various] Disable sandbox in Chrome dart tests (flutter/packages#8909) 2025-03-25 [email protected] [tool] Move changed file detection to base command class (flutter/packages#8730) 2025-03-25 [email protected] [Camera] Add lens type information (iOS) (flutter/packages#8723) 2025-03-25 [email protected] [pigeon] kotlin equality methods (flutter/packages#8887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Maurice Parrish <[email protected]>

flutter/packages#8888)

…#8888) MDnsClient::Listen now supports an optional onError callback function, called in case of a stream error. If omitted any errors on the stream are considered unhandled, and will be passed to the current [Zone]'s error handler. By default unhandled async errors are treated as if they were uncaught top-level errors. This fixes an unhandled exception occuring (tested on Android), when the network is disconnected. Fixes flutter/flutter#165482 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. How can a test be added? It would need to disconnect the device from WLAN beforehand.

alexander-irion requested a review from vashworth as a code owner March 18, 2025 19:32

github-actions bot added the p: multicast_dns label Mar 18, 2025

stuartmorgan-g marked this pull request as draft March 18, 2025 20:00

stuartmorgan-g removed the request for review from vashworth March 18, 2025 20:00

alexander-irion force-pushed the main branch from 92bf8d2 to 60eb82f Compare March 19, 2025 10:19

alexander-irion changed the title ~~MDnsClient: listen supports onError callback~~ [multicast_dns] MDnsClient::listen supports onError callback Mar 19, 2025

alexander-irion force-pushed the main branch from 60eb82f to 41222a4 Compare March 19, 2025 10:30

alexander-irion force-pushed the main branch from 41222a4 to cfec2f4 Compare March 19, 2025 11:30

alexander-irion mentioned this pull request Mar 20, 2025

MDnsClient throws uncatched exception when Android device disconnected from network flutter/flutter#165482

Closed

alexander-irion force-pushed the main branch from cfec2f4 to e3e4729 Compare March 20, 2025 12:20

alexander-irion force-pushed the main branch from e3e4729 to 0a87e5b Compare March 20, 2025 12:28

alexander-irion force-pushed the main branch from 0a87e5b to 52d7a4c Compare March 20, 2025 12:36

alexander-irion marked this pull request as ready for review March 20, 2025 13:41

vashworth approved these changes Mar 21, 2025

View reviewed changes

vashworth requested a review from stuartmorgan-g March 21, 2025 15:12

Adjust CHANGELOG wording

82aa495

stuartmorgan-g requested changes Apr 1, 2025

View reviewed changes

Change version and adapt comment

27cdff3

- Change version to 0.3.3 - Adapt comment about new parameter

alexander-irion requested a review from stuartmorgan-g April 2, 2025 10:11

stuartmorgan-g approved these changes Apr 2, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot merged commit 07496eb into flutter:main Apr 2, 2025
82 checks passed

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166457

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

07496eb03 [multicast_dns] MDnsClient::listen supports onError callback (

fd273b6

flutter/packages#8888)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166469

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

07496eb03 [multicast_dns] MDnsClient::listen supports onError callback (

601afd0

flutter/packages#8888)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166472

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

07496eb03 [multicast_dns] MDnsClient::listen supports onError callback (

f1ce2d7

flutter/packages#8888)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166534

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025

07496eb03 [multicast_dns] MDnsClient::listen supports onError callback (

c50840c

flutter/packages#8888)

[multicast_dns] MDnsClient::listen supports onError callback #8888

[multicast_dns] MDnsClient::listen supports onError callback #8888

Uh oh!

Conversation

alexander-irion commented Mar 18, 2025 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

flutter-dashboard bot commented Mar 18, 2025

Uh oh!

google-cla bot commented Mar 18, 2025

Uh oh!

stuartmorgan-g commented Mar 18, 2025

Uh oh!

alexander-irion commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexander-irion commented Mar 20, 2025

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

alexander-irion commented Mar 25, 2025

Uh oh!

vashworth commented Mar 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexander-irion commented Mar 18, 2025 •

edited by stuartmorgan-g

Loading

alexander-irion commented Mar 19, 2025 •

edited

Loading