-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Comparing changes
Open a pull request
base repository: flutter/plugins
base: 1a56bb2
head repository: flutter/plugins
compare: 19468e0
- 12 commits
- 32 files changed
- 6 contributors
Commits on Dec 13, 2021
-
[video_player] Fix a flaky test (#4611)
The 'reports buffering status' test was written in an unnecessary complicated way that used pairs of completers and booleans that tracked the same thing, and more importantly had a bug (hidden by the fact that this package is still on legacy analysis options) where the `await` statements weren't actually doing anything, because they were not actually `await`ing futures. This fixes the lack of awaits—which should fix the flake—and removes the unnecessary booleans. Fixes flutter/flutter#94775
Configuration menu - View commit details
-
Copy full SHA for bfa3438 - Browse repository at this point
Copy the full SHA bfa3438View commit details
Commits on Dec 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 453089d - Browse repository at this point
Copy the full SHA 453089dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 910055b - Browse repository at this point
Copy the full SHA 910055bView commit details -
[flutter_plugin_tools] Auto-retry failed FTL tests (#4610)
Currently the flake situation for Firebase Test Lab tests is very bad, and the task running those tests are some of the slowest tasks in the CI. Re-running failed tests is slow, manual work that is signficantly affecting productivity. There are plans to actually address the flake in the short-to-medium term, but in the immediate term this will improve the CI situation, as well as reducing the drag on engineering time that could be spent on the root causes. Part of flutter/flutter#95063
Configuration menu - View commit details
-
Copy full SHA for 92539fc - Browse repository at this point
Copy the full SHA 92539fcView commit details
Commits on Dec 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ee97b65 - Browse repository at this point
Copy the full SHA ee97b65View commit details
Commits on Dec 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 73cb8a7 - Browse repository at this point
Copy the full SHA 73cb8a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d383fad - Browse repository at this point
Copy the full SHA d383fadView commit details
Commits on Dec 19, 2021
-
[ci] Move Android build-all CI to heavy workload (#4624)
This task's memory usage is very close to the 4GB limit of the light-workload machines, and sometimes goes over and causes flaky failures.
Configuration menu - View commit details
-
Copy full SHA for 29b6373 - Browse repository at this point
Copy the full SHA 29b6373View commit details -
[video_player] Remove test code from platform interface (#4589)
This is a breaking change to video_player_platform_interface to remove Pigeon mocks from the public interface. These should never have been there, as tests in packages outside of the platform interface should be mocking the platform interface rather than the method channel, but the app-facing tests weren't rewritten when they should have been so they ended up published to support the legacy tests. This creates an unwanted non-dev dependency on `flutter_test`, in addition to promoting an anti-pattern. While making the breaking change, this also adopts `PlatformInterface`, removing `isMock` in favor of the standard mixin pattern provided by the base class. Part of flutter/flutter#83562
Configuration menu - View commit details
-
Copy full SHA for 6531740 - Browse repository at this point
Copy the full SHA 6531740View commit details
Commits on Dec 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3972212 - Browse repository at this point
Copy the full SHA 3972212View commit details -
[video_player] Add 5.0 interface support (#4627)
Allows the other video_player packages to use either 4.x or 5.x of `video_player_platform_interface`, since the only breaking change doesn't affect them (as it just removes test code that they no longer use). This allows clients of `video_player` to no longer have a transitive dependency on test packages, but doesn't create any version lock with any unendorsed implementations that might exist. Fixes flutter/flutter#83562
Configuration menu - View commit details
-
Copy full SHA for c9c234a - Browse repository at this point
Copy the full SHA c9c234aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19468e0 - Browse repository at this point
Copy the full SHA 19468e0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1a56bb2...19468e0