This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Add 5.0 interface support #4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the other video_player packages to use either 4.x or 5.x of `video_player_platform_interface`, since the only breaking change doesn't affect them (as it just removes test code that they no longer use). This allows clients of `video_player` to no longer have a transitive dependency on test packages, but doesn't create any version lock with any unendorsed implementations that might exist. Fixes flutter/flutter#83562
cyanglaz
approved these changes
Dec 20, 2021
| @@ -1,3 +1,8 @@ | |||
| ## 2.2.9 | |||
|
|
|||
| * Adds compatibility with `video_player_platform_interface` 5.0, which does not | |||
There was a problem hiding this comment.
Should we also mentioned the CONTRIBUTING.md change here?
There was a problem hiding this comment.
It seemed extremely niche (the audience would be "people who have contributed to video_player in the past, but don't read our current contributing docs"), so I didn't think it was worth mentioning.
|
Overriding incorrect submit-queue status |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Allows the other video_player packages to use either 4.x or 5.x of `video_player_platform_interface`, since the only breaking change doesn't affect them (as it just removes test code that they no longer use). This allows clients of `video_player` to no longer have a transitive dependency on test packages, but doesn't create any version lock with any unendorsed implementations that might exist. Fixes flutter/flutter#83562
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the other video_player packages to use either 4.x or 5.x of
video_player_platform_interface, since the only breaking changedoesn't affect them (as it just removes test code that they no longer
use). This allows clients of
video_playerto no longer have atransitive dependency on test packages, but doesn't create any version
lock with any unendorsed implementations that might exist.
Since this touches
video_player, it makes the opportunistic changeof cleaning up
CONTRIBUTING.md, removing discussion of howto modify federated plugins which is now part of the wiki for the
repository as a whole.
Fixes flutter/flutter#83562
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).