Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Add 5.0 interface support #4627

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[video_player] Add 5.0 interface support #4627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.2.9

* Adds compatibility with `video_player_platform_interface` 5.0, which does not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mentioned the CONTRIBUTING.md change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed extremely niche (the audience would be "people who have contributed to video_player in the past, but don't read our current contributing docs"), so I didn't think it was worth mentioning.

include non-dev test dependencies.

## 2.2.8

* Changes the way the `VideoPlayerPlatform` instance is cached in the
Expand Down
49 changes: 0 additions & 49 deletions packages/video_player/video_player/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,52 +31,3 @@ pigeon, not your version or the version on master.
In either case, the configuration will be obtained automatically from
the `pigeons/messages.dart` file (see `configurePigeon` at the bottom
of that file).

While contributing, you may also want to set the following dependency
overrides:

```yaml
dependency_overrides:
video_player_platform_interface:
path:
../video_player_platform_interface
video_player_web:
path:
../video_player_web
```

## Publishing plugin updates that span multiple plugin packages

If your change affects both the interface package and the
implementation packages, then you will need to publish a version of
the plugin in between landing the interface changes and the
implementation changes, since the implementations depend on the
interface via pub.

To do this, follow these steps:

1. Create a PR that has all the changes, and update the
`pubspec.yaml`s to have path-based dependency overrides as described
in the "Updating pigeon-generated files" section above.

2. Upload that PR and get it reviewed and into a state where the only
test failure is the one complaining that you can't publish a package
that has dependency overrides.

3. Create a PR that's a subset of the one in the previous step that
only includes the interface changes, with no dependency overrides, and
submit that.

4. Once you have had that reviewed and landed, publish the interface
parts of the plugin to pub.

5. Now, update the original full PR to not use dependency overrides
but to instead refer to the new version of the plugin, and sync it to
master (so that the interface changes are gone from the PR). Submit
that PR.

6. Once you have had _that_ PR reviewed and landed, publish the
implementation parts of the plugin to pub.

You may need to publish each implementation package independently of
the main package also, depending on exactly what your change entails.
4 changes: 2 additions & 2 deletions packages/video_player/video_player/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
widgets on Android, iOS, and web.
repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.2.8
version: 2.2.9

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -24,7 +24,7 @@ dependencies:
flutter:
sdk: flutter
meta: ^1.3.0
video_player_platform_interface: ^4.2.0
video_player_platform_interface: ">=4.2.0 <6.0.0"
video_player_web: ^2.0.0
html: ^0.15.0

Expand Down
7 changes: 6 additions & 1 deletion packages/video_player/video_player_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
## 2.0.5

* Adds compatibility with `video_player_platform_interface` 5.0, which does not
include non-dev test dependencies.

## 2.0.4

* Adopt `video_player_platform_interface` 4.2 and opt out of `contentUri` data source.

## 2.0.3

* Add `implements` to pubspec.
Expand Down
4 changes: 2 additions & 2 deletions packages/video_player/video_player_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_web
description: Web platform implementation of video_player.
repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.0.4
version: 2.0.5

environment:
sdk: ">=2.12.0 <3.0.0"
Expand All @@ -23,7 +23,7 @@ dependencies:
sdk: flutter
meta: ^1.3.0
pedantic: ^1.10.0
video_player_platform_interface: ^4.2.0
video_player_platform_interface: ">=4.2.0 <6.0.0"

dev_dependencies:
flutter_test:
Expand Down