Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] fix camera update LatLngBounds.builder #2642

Closed
wants to merge 3 commits into from

Conversation

everton-e26
Copy link

Description

In camera update call LatLngBounds does not correctly calculate the center of the coordinates, to fix it I used LatLngBounds.Builder as I described at flutter/flutter#25298 (comment)

Related Issues

flutter/flutter#25298

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@everton-e26
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 9, 2020
@cyanglaz
Copy link
Contributor

Thanks for opening this PR. Can we add an e2e test that fails on the original code and pass on the new code?

@cyanglaz cyanglaz self-assigned this Apr 20, 2020
@ditman
Copy link
Member

ditman commented Apr 21, 2020

This PR is compatible with the upcoming google_maps_flutter federation PR.

@everton-e26
Copy link
Author

Thanks for opening this PR. Can we add an e2e test that fails on the original code and pass on the new code?

Sorry but I can't implement this tests right now

@cyanglaz
Copy link
Contributor

@everton-e26 Friendly ping :) Do you think you can work on the tests?

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@cyanglaz
Copy link
Contributor

@everton-e26 Pinging again :) Do you still plan to work on this?

@stuartmorgan-g
Copy link
Contributor

Closing due to inactivity. If you're interested in working on this again, please let us know and we can re-open it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants