-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] fix camera update LatLngBounds.builder #2642
Conversation
to fix animate camera zoom
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for opening this PR. Can we add an e2e test that fails on the original code and pass on the new code? |
This PR is compatible with the upcoming google_maps_flutter federation PR. |
Sorry but I can't implement this tests right now |
@everton-e26 Friendly ping :) Do you think you can work on the tests? |
This pull request is not suitable for automatic merging in its current state.
|
@everton-e26 Pinging again :) Do you still plan to work on this? |
Closing due to inactivity. If you're interested in working on this again, please let us know and we can re-open it. |
Description
In camera update call LatLngBounds does not correctly calculate the center of the coordinates, to fix it I used LatLngBounds.Builder as I described at flutter/flutter#25298 (comment)
Related Issues
flutter/flutter#25298
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?