This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Migrate plugin to platform_interface API. #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I consent. |
I think you left off the googlebot part. |
12 tasks
* Make the method_channel implementation private, so it can't be imported from other packages. * Fix all the problems with Future<void> functions not returning a future.
…ort from core plugin to maintain current API.
…by other toJson methods.
…port from the core plugin to preserve public API.
…Json where needed.
The interface can be a singleton, but implementations can still keep references to multiple different method channels.
Wire them up in the method channel. Add Event types so we can filter views of the stream later.
Make the event handler methods in the widget less stringly typed.
0874a5c to
fcdc7b1
Compare
This was referenced Apr 21, 2020
|
All tests pass, awaiting for @cylyl to consent (mentioning the googlebot :P) |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cyanglaz
reviewed
Apr 23, 2020
packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart
Show resolved
Hide resolved
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…ter#2674) This change migrates the core `google_maps_flutter` plugin to use the APIs provided by the `google_maps_flutter_platform_interface` package. This allows for federated implementations for other platforms to be made.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…ter#2674) This change migrates the core `google_maps_flutter` plugin to use the APIs provided by the `google_maps_flutter_platform_interface` package. This allows for federated implementations for other platforms to be made.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…ter#2674) This change migrates the core `google_maps_flutter` plugin to use the APIs provided by the `google_maps_flutter_platform_interface` package. This allows for federated implementations for other platforms to be made.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change migrates the core
google_maps_flutterplugin to use the APIs provided by thegoogle_maps_flutter_platform_interfacepackage.Related Issues
WIP. BLOCKED BY: [google_maps_flutter_platform_interface] Bump to 1.0.1 version. #2677. Done.Tests
google_maps_flutter/test$ flutter test
google_maps_flutter/example$ flutter drive -t test_driver/google_maps_e2e.dart -d emu
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
This should not be a breaking change, but the change is significant, so the major version has been bumped to 0.6.0.