Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Adds support for serverAuthCode. #4034

Closed
wants to merge 5 commits into from

Conversation

vlidholt
Copy link

@vlidholt vlidholt commented Jun 9, 2021

Fixes: flutter/flutter#57712

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Jun 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution. I've restored the checklist that you removed from the PR template; it's there because those steps are important, and you've skipped many of them, including critical ones.

I'll mark this as a draft for now; once you've worked through the checklist and addressed the items there, please remove the draft designation and we can triage it for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft June 10, 2021 20:12
@vlidholt
Copy link
Author

It was my hope that someone at Google would pick it up and fix it, as it is a pretty big issue. Currently not possible to do server-side authentication with Google sign-in, something that I can imagine is a common use case with Flutter. I'll see if I have time to make a new pull request that ticks off the list.

@vlidholt
Copy link
Author

@stuartmorgan closing this as I submitted a new pull request here: #4070

@vlidholt vlidholt closed this Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sign In 4.5.1 - ServerAuthCode returns null value
3 participants