Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Adds support for serverAuthCode. #4070

Closed
wants to merge 1 commit into from
Closed

[google_sign_in] Adds support for serverAuthCode. #4070

wants to merge 1 commit into from

Conversation

vlidholt
Copy link

Adds missing support for serverAuthCode in google_sign_in packages. Without this fix, it's not possible to do server-side authentification with Google sign-in.

This module has very limited tests. It's also very hard to test this fix automatically as it would include talking with Google's API:s, having access to API keys, and doing non-Flutter actions such as signing in through native code.

Fixes:
flutter/flutter#57712

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@vlidholt vlidholt mentioned this pull request Jun 18, 2021
Closed
11 tasks
@stuartmorgan-g
Copy link
Contributor

This module has very limited tests.

https://github.com/flutter/flutter/wiki/Plugin-Tests#faq-do-i-need-to-add-tests-even-if-the-part-of-the-code-im-changing-isnt-already-tested

It's also very hard to test this fix automatically as it would include talking with Google's API:s, having access to API keys, and doing non-Flutter actions such as signing in through native code.

An end-to-end test might be difficult, but unit testing each section to make sure the arguments are being passed thorough correctly should not be very difficult, and would prevent a type of bug we have had in the past.

Fixes:
flutter/flutter#57712

I don't see any Android changes here. Was this already fixed for Android?

@rodion-m
Copy link

I checked, serverAuthCode is retrieved correctly now. @stuartmorgan what prevents you from merging it?

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan what prevents you from merging it?

The unaddressed comments and questions in the comment directly above yours.

@stuartmorgan-g
Copy link
Contributor

@karthik-js Please read https://github.com/flutter/flutter/wiki/Tree-hygiene#getting-a-code-review. Approving PRs is reserved for contributors; approving a PR as a non-contributor serves no purpose, and causes confusion for people following the state of the PR.

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthik-js karthik-js karthik-js approved these changes

Assignees
No one assigned
Labels
cla: yes needs tests p: google_sign_in platform-ios platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vlidholt @stuartmorgan-g @rodion-m @karthik-js