This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[video_player] interface: add support for content-uri based videos (a… #4307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
stuartmorgan-g
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
…ideos (android only) (flutter/plugins#4307)
It looks like this commit might be causing a failure on the framework tree: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20flutter_plugins/3326/overview |
This was referenced Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
…ideos (android only) (flutter/plugins#4307)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
…ideos (android only) (flutter/plugins#4307)
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Sep 10, 2021
* master: [webview_flutter] Add download listener to Android webview (flutter#4322) [video_player] add support for content-uri based videos (flutter#4330) [webview_flutter] Implementation of the webview_flutter_platform_interface package (flutter#4302) [camera] Bump minimum Flutter version and iOS deployment target (flutter#4327) [video_player] interface: add support for content-uri based videos (android only) (flutter#4307) Ignore unnecessary_import in legacy analysis options (flutter#4129) [ci] Enable the new Windows targets (flutter#4325) # Conflicts: # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewBuilder.java
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: video_player
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of #4261: platform_interface changes only.
This PR adds playback from contentUri support for the video_player plugin (Android only).
The current Android implementation uses ExoPlayer, which already supports playback from uri, so this change is just to surface contentUri as a valid video datasource on the dart side.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#88130
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.