Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Remove iOS 9 availability check around ultra high capture sessions #4362

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[camera] Remove iOS 9 availability check around ultra high capture sessions #4362

merged 1 commit into from
Sep 17, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 17, 2021

This iOS 9.0 availability check should have been removed as part of #4327. It is no longer needed now that the minimum iOS version is 9.0.

Part of flutter/flutter#84198

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Sep 17, 2021
@google-cla google-cla bot added the cla: yes label Sep 17, 2021
stuartmorgan-g
stuartmorgan-g approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all of this cleanup!

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 17, 2021
@fluttergithubbot fluttergithubbot merged commit 1751746 into flutter:master Sep 17, 2021
@jmagman jmagman deleted the camera-9 branch September 17, 2021 23:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 18, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
@engine-flutter-autoroll
1751746 [camera] Remove iOS 9 availability check around ultra high ca…
1f494b9 
…pture sessions (flutter/plugins#4362)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@jmagman @amantoux
[camera] Remove iOS 9 availability check around ultra high capture se…
bc6dd91 
…ssions (flutter#4362)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@jmagman @KyleFin
[camera] Remove iOS 9 availability check around ultra high capture se…
8644bc0 
…ssions (flutter#4362)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

@jmagman jmagman

Labels
cla: yes p: camera platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @stuartmorgan-g @fluttergithubbot