Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Added initial support. #4437

Closed
wants to merge 1 commit into from
Closed

[image_picker] Added initial support. #4437

wants to merge 1 commit into from

Conversation

azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Oct 19, 2021 •
edited
Loading

Adds windows(Win32) support for the image_picker.

Fixes flutter/flutter#92108

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@azchohfi azchohfi requested a review from cyanglaz as a code owner October 19, 2021 17:51
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@azchohfi azchohfi force-pushed the image_picker_windows branch 3 times, most recently from b985257 to 7b6b8da Compare October 19, 2021 20:09
@azchohfi
Copy link
Contributor Author

@cyanglaz It seems that the build machine doesn't have ATL installed ("C++ ATL for latest v142 build tools (x86 & x64")
image
No idea how to fix this.

@azchohfi azchohfi force-pushed the image_picker_windows branch from 7b6b8da to f8bfe9c Compare October 19, 2021 20:38
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Oct 19, 2021 •
edited
Loading

@cyanglaz It seems that the build machine doesn't have ATL installed ("C++ ATL for latest v142 build tools (x86 & x64") image No idea how to fix this.

It would require filing an issue, to have the CIPD package for the machines updated. However, this would be a new build requirement for every Flutter developer using the plugin, which isn't ideal.

Can you elaborate on why it's necessary? It looks like there's a lot here that's like #4424, which doesn't need ATL.

(I'm skimming on a phone so may be missing important details, but is this just a set of filter specs? If so we should build this as a wrapper around that plugin instead of have two copies of file dialog code.)

@stuartmorgan-g
Copy link
Contributor

@azchohfi Are you planning on continuing with this PR?

@azchohfi
Copy link
Contributor Author

I believe it would be best to abandon this, in favor for something based on top of #4424.

@stuartmorgan-g
Copy link
Contributor

Sounds good; I'll close this then, and once that PR lands if you want to adapt the filter code here to a wrapper-based implementation that would be great.

@azchohfi
Copy link
Contributor Author

Status update: I've got this implemented for when source == ImageSource.gallery, using a wrapper on the FileSelector for windows. Still implementing it for when source == ImageSource.camera, which will use the camera_windows plugin.

@stuartmorgan-g
Copy link
Contributor

Great! Feel free to submit a PR with what you currently have; we can land it as an unendorsed implementation that only supports the gallery source, then camera can be added in a later PR. Incremental PRs are definitely encouraged :)

@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@azchohfi
Copy link
Contributor Author

@stuartmorgan #4863

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: image_picker platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[image_picker] Windows support
2 participants
@azchohfi @stuartmorgan-g