[image_picker] Added image_picker_for_windows. #4863

azchohfi · 2022-02-15T22:46:50Z

This PR adds a very simplistic Windows implementation of the image_picker plugin, which uses the file_selector plugin to get images or videos from the "gallery". This initial implementation doesn't yet support ImageSource.camera (falls back to gallery).

Fixes flutter/flutter#92108

Pre-launch Checklist

flutter-dashboard · 2022-02-15T22:46:52Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g

Looks good! This will need Dart unit tests that sets a mock FileSelectorPlatform implementation as FileSelectorPlatform.instance and validates that the expected calls are made. And also that registerWith works (as in other Dart plugin implementation tests).

While the logic is currently pretty trivial, having tests in place is important as we change it over time.

packages/image_picker/image_picker_for_windows/AUTHORS

packages/image_picker/image_picker_for_windows/README.md

packages/image_picker/image_picker_for_windows/example/lib/main.dart

packages/image_picker/image_picker_for_windows/lib/image_picker_for_windows.dart

packages/image_picker/image_picker_for_windows/pubspec.yaml

azchohfi · 2022-02-17T02:33:17Z

I believe I got it all. Let me know if there is anything missing.

stuartmorgan-g

Just a few more minor things, sorry I missed some of these on the first review. Thanks for implementing this!

Adding @cbracken for secondary review.

packages/image_picker/image_picker_windows/README.md

packages/image_picker/image_picker_windows/example/lib/main.dart

packages/image_picker/image_picker_windows/lib/image_picker_windows.dart

azchohfi · 2022-02-17T20:20:18Z

Oh, I believe I need to add the image_picker_windows to the exclude_integration_win32.yaml file.

azchohfi · 2022-02-23T23:13:07Z

@stuartmorgan anything else needed here?

stuartmorgan-g · 2022-02-24T00:07:20Z

Sorry for the slow response, I haven't had much time for reviews because of the build issue with VS 17.1.0.

stuartmorgan-g

A few other small things, but otherwise it should be good from my side.

packages/image_picker/image_picker_windows/README.md

packages/image_picker/image_picker_windows/lib/image_picker_windows.dart

stuartmorgan-g · 2022-03-04T18:39:55Z

packages/image_picker/image_picker_windows/test/image_picker_windows_test.dart

+        expect(
+          log,
+          <Matcher>[
+            isMethodCall('openFile', arguments: <String, dynamic>{


You are testing implementation details of file_selector here; these tests would all break if FileSelectorWindows changed its implementation (e.g., switched to a Dart implementation, or to using Pigeon).

Even though you can't use FileSelectorPlatform.instance in the implementation, you can still write the implementation against a FileSelectorPlatform variable, and just manually instantiate it with a FileSelectorWindows. Then you can make that instance settable by tests, and insert a mock implementation in these tests and validate against that mock. Then it doesn't matter how FileSelectorWindows works, because you'll just be verifying that you're using its API correctly.

@stuartmorgan I just pushed the changes. I believe that is what you means, which I agree that is a way better approach.

azchohfi · 2022-03-11T01:20:06Z

@stuartmorgan anything needed here?

stuartmorgan-g

One comment about adding a few more tests, but LGTM otherwise. The main thing this is waiting on is just the second review from @cbracken.

packages/image_picker/image_picker_windows/test/image_picker_windows_test.dart

azchohfi · 2022-03-17T19:05:02Z

@cbracken anything else needed here?

azchohfi · 2022-03-28T18:03:53Z

Merged main into this branch just to keep it up to date.
@stuartmorgan / @cbracken let me know if there is anything else needed here.

azchohfi · 2022-04-07T23:05:58Z

Merged main again, just to keep this updated. Unlike the local_auth plugin, the image_picker plugin is already federated. @stuartmorgan / @cbracken what is keeping this PR from being reviewed/merged?

stuartmorgan-g · 2022-04-08T00:37:44Z

@stuartmorgan / @cbracken what is keeping this PR from being reviewed/merged?

It's still @cbracken having time to review; Flutter policy requires two reviews for PRs from people outside the org before landing.

cbracken

Overall looks good! Just a few comments.

cbracken · 2022-04-12T21:44:33Z

packages/image_picker/image_picker_windows/example/lib/main.dart

+      await _playVideo(file);
+    } else if (isMultiImage) {
+      await _displayPickImageDialog(context!,
+          (double? maxWidth, double? maxHeight, int? quality) async {


Optionally, consider breaking this out to a separate private method like _handleMultiImagePicked to reduce the amount of handling directly under _onImageButtonPressed.

cbracken · 2022-04-12T21:47:20Z

packages/image_picker/image_picker_windows/example/lib/main.dart

+      });
+    } else {
+      await _displayPickImageDialog(context!,
+          (double? maxWidth, double? maxHeight, int? quality) async {


Similar comment here; something like _handleSingleImagePicked.

packages/image_picker/image_picker_windows/example/lib/main.dart

cbracken · 2022-04-18T17:45:17Z

packages/image_picker/image_picker_windows/example/lib/main.dart

+  }
+
+  dynamic _pickImageError;
+  bool isVideo = false;


Consider making this private.

cbracken · 2022-04-18T17:47:28Z

packages/image_picker/image_picker_windows/example/lib/main.dart

+  bool isVideo = false;
+
+  VideoPlayerController? _controller;
+  VideoPlayerController? _toBeDisposed;


Since there's a little complexity around the use of this field, add a doc comment explaining how it's used.

packages/image_picker/image_picker_windows/lib/image_picker_windows.dart

azchohfi · 2022-04-18T22:46:40Z

@cbracken let me know what you think.

cbracken

Thanks!

…gins#4863)

[image_picker] Added image_picker_for_windows.

031dfd2

flutter-dashboard bot added the needs tests label Feb 15, 2022

azchohfi mentioned this pull request Feb 15, 2022

[image_picker] Added initial support. #4437

Closed

11 tasks

github-actions bot added p: image_picker platform-windows labels Feb 15, 2022

stuartmorgan-g suggested changes Feb 16, 2022

View reviewed changes

azchohfi added 2 commits February 16, 2022 16:58

Merge branch 'main' into image_picker_win_fs

d4ddc85

More windows work.

ad41c89

stuartmorgan-g suggested changes Feb 17, 2022

View reviewed changes

stuartmorgan-g requested a review from cbracken February 17, 2022 18:43

azchohfi added 2 commits February 17, 2022 10:55

Merge branch 'main' into image_picker_win_fs

0deefd1

Applied PR feedback.

59b831d

azchohfi force-pushed the image_picker_win_fs branch from d5e2767 to 59b831d Compare February 17, 2022 19:36

Added image_picker_windows tests.

fb7ac4d

Excl image_picker_windows win32 integration tests.

aeb1d04

azchohfi requested a review from stuartmorgan-g February 17, 2022 21:01

EdGeraghty mentioned this pull request Feb 23, 2022

Windows client cannot use image picker syphon-org/syphon#405

Open

Merge branch 'main' into image_picker_win_fs

de25b0a

stuartmorgan-g mentioned this pull request Feb 24, 2022

Decide how to handle Dart plugin registration for direct implementation dependencies flutter/flutter#99083

Closed

azchohfi added 4 commits February 24, 2022 13:11

Merge branch 'main' into image_picker_win_fs

e63c96a

[image_picker_windows] Added its own FileSelectorWindows instance

08fa003

Merge branch 'main' into image_picker_win_fs

e45109e

Fix test.

69a1b81

stuartmorgan-g suggested changes Feb 28, 2022

View reviewed changes

Merge branch 'main' into image_picker_win_fs

7ab06be

stuartmorgan-g suggested changes Mar 4, 2022

View reviewed changes

azchohfi added 3 commits March 7, 2022 14:15

Improved UnimplementedError message on Windows.

922b42b

Changed tests based on PR feedback.

8ab457b

Merge branch 'main' into image_picker_win_fs

6c11ff2

stuartmorgan-g removed the needs tests label Mar 11, 2022

stuartmorgan-g approved these changes Mar 11, 2022

View reviewed changes

packages/image_picker/image_picker_windows/test/image_picker_windows_test.dart Show resolved Hide resolved

Added tests for unimplemented camera source.

d4b7821

Merge branch 'main' into image_picker_win_fs

f5dbb22

Merge branch 'main' into image_picker_win_fs

34d1c2f

cbracken suggested changes Apr 18, 2022

View reviewed changes

Merge branch 'main' into image_picker_win_fs

ea55c42

azchohfi mentioned this pull request Apr 18, 2022

[image_picker_windows] The Windows implementation of the image_picker should support ImageSource.camera. flutter/flutter#102115

Closed

Applied PR feedback.

c3f46ee

azchohfi requested a review from cbracken April 18, 2022 22:46

Merge branch 'main' into image_picker_win_fs

65e4f57

cbracken approved these changes Apr 20, 2022

View reviewed changes

stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 21, 2022

stuartmorgan-g mentioned this pull request Apr 21, 2022

[image_picker] Endorse Windows implementation flutter/flutter#102320

Closed

3 tasks

fluttergithubbot merged commit 92a1ffe into flutter:main Apr 21, 2022

azchohfi deleted the image_picker_win_fs branch April 21, 2022 18:45

engine-flutter-autoroll mentioned this pull request Apr 22, 2022

Roll Plugins from 5c3c1b8aac06 to ca63d964d9fd (10 revisions) flutter/flutter#102379

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 22, 2022

92a1ffeda [image_picker] Added image_picker_for_windows. (flutter/plu…

ddfcc60

…gins#4863)

cassioso pushed a commit to cassioso/plugins that referenced this pull request May 10, 2022

[image_picker] Added image_picker_for_windows. (flutter#4863)

81a209f

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[image_picker] Added image_picker_for_windows. (flutter#4863)

7787f3b

[image_picker] Added image_picker_for_windows. #4863

[image_picker] Added image_picker_for_windows. #4863

Uh oh!

Conversation

azchohfi commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 15, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azchohfi commented Feb 17, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azchohfi commented Feb 17, 2022

Uh oh!

azchohfi commented Feb 23, 2022

Uh oh!

stuartmorgan-g commented Feb 24, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

azchohfi Mar 7, 2022

Choose a reason for hiding this comment

Uh oh!

azchohfi commented Mar 11, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azchohfi commented Mar 17, 2022

Uh oh!

azchohfi commented Mar 28, 2022

Uh oh!

azchohfi commented Apr 7, 2022

Uh oh!

stuartmorgan-g commented Apr 8, 2022

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

cbracken Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

cbracken Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbracken Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

azchohfi commented Feb 15, 2022 •

edited

Loading