Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Federate mobile implementations #4465

Merged
merged 9 commits into from
Nov 10, 2021
Merged

[path_provider] Federate mobile implementations #4465

merged 9 commits into from
Nov 10, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure.

Temporarily marks path_provider as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.

Part of flutter/flutter#68498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@stuartmorgan-g
Copy link
Contributor Author

For ease of review, the individual commits are:

  1. Copy path_provider as-is to the _android and _ios versions, deleting the files that are no longer relevant from each package.
  2. Fix all of the pubspecs and CHANGELOGs
  3. Fix the Android and iOS tests to use the platform interface instead of the app-facing package (per standard repo practice, to avoid dependencies on a higher layer)
  4. Adjust the podspec and gradle files for the new names

@stuartmorgan-g stuartmorgan-g force-pushed the path-provider-full-federation branch from 5dd908f to 89a06d5 Compare November 1, 2021 19:55
bparrishMines
bparrishMines reviewed Nov 4, 2021
View reviewed changes
bparrishMines
bparrishMines approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 0cfbe17 into flutter:master Nov 10, 2021
@stuartmorgan-g stuartmorgan-g deleted the path-provider-full-federation branch November 10, 2021 19:48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
0cfbe17 [path_provider] Federate mobile implementations (flutter/plug…
289b2af 
…ins#4465)
@stuartmorgan-g stuartmorgan-g mentioned this pull request Nov 16, 2021
Closed
11 tasks
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan-g @amantoux
[path_provider] Federate mobile implementations (flutter#4465)
e0d9dcb 
Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure.

Temporarily marks `path_provider` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.

Part of flutter/flutter#68498
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
[path_provider] Federate mobile implementations (flutter#4465)
40cce43 
Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure.

Temporarily marks `path_provider` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.

Part of flutter/flutter#68498
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jan 26, 2022
Closed
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

Assignees
No one assigned
Labels
cla: yes p: path_provider platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @bparrishMines