Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Add native iOS implementation of platform interface #4699

Closed
wants to merge 11 commits into from
Closed

[local_auth] Add native iOS implementation of platform interface #4699

wants to merge 11 commits into from

Conversation

BeMacized
Copy link
Contributor

@BeMacized BeMacized commented Jan 26, 2022 •
edited
Loading

This PR is one in a series to move the local_auth plugin to a federated architecture.

  1. Move local_auth into a subfolder and add a platform interface
    ([local_auth] Add platform interface to prepare for migration to federated architecture #4697)
  2. Add native implementations for the interface
  3. Refactor app facing plugin to make use of the platform interface and native implementations.
    ([local_auth] Refactor package to make use of new platform interface and native implementations #4701)

This PR remains in draft mode until the PR for the platform interface package has been merged and published (#4697).

Relevant issues:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

This was referenced Jan 26, 2022
Merged
Merged
Merged
stuartmorgan-g
stuartmorgan-g suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the move of the app-facing package as a precursor PR to remove complexity from the substantive PR.

@BeMacized BeMacized force-pushed the local_auth/federation_ios branch from d18881c to 24556fa Compare January 27, 2022 11:18
@BeMacized BeMacized marked this pull request as ready for review February 15, 2022 09:52
stuartmorgan-g
stuartmorgan-g suggested changes Feb 15, 2022
View reviewed changes
@stuartmorgan-g stuartmorgan-g mentioned this pull request Feb 15, 2022
Merged
11 tasks
@stuartmorgan-g
Copy link
Contributor

You'll need to resolve with #3806, but it should be straightforward.

@BeMacized BeMacized force-pushed the local_auth/federation_ios branch from 0a3a26d to 60de1a7 Compare February 23, 2022 15:17
@BeMacized BeMacized marked this pull request as draft February 23, 2022 15:34
@BeMacized BeMacized marked this pull request as ready for review March 11, 2022 13:00
@stuartmorgan-g stuartmorgan-g self-requested a review March 16, 2022 17:07
stuartmorgan-g
stuartmorgan-g suggested changes Mar 17, 2022
View reviewed changes
packages/local_auth/local_auth/test/local_auth_test.dart
'signInTitle': androidSignInTitle,
},
),
isMethodCall('authenticate',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in the app-facing package need to be rewritten to mock the platform interface, not the method channel. Whether any given implementation uses this platform channel format is an implementation detail of what is now a separate package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this has been done in #4701 which contains all changes for the app facing package.

stuartmorgan-g
stuartmorgan-g suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been updated to do a move, rather than copy, of the iOS implementation (which is why it's not suffering from #4700 (review))

@BeMacized BeMacized mentioned this pull request Apr 7, 2022
Merged
11 tasks
@BeMacized BeMacized mentioned this pull request Apr 8, 2022
Merged
11 tasks
@BeMacized BeMacized marked this pull request as draft April 8, 2022 07:41
@BeMacized
Copy link
Contributor Author

I couldn't figure out how to update this PR to register the files as being moved, so I've created a new PR where this is fixed instead. Closing this PR as it is now superseded by:

@BeMacized BeMacized closed this Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom left review comments

@stuartmorgan-g stuartmorgan-g stuartmorgan-g requested changes

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu will be requested when the pull request is marked ready for review LouiseHsu is a code owner

Assignees
No one assigned
Labels
p: local_auth platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeMacized @stuartmorgan-g @mvanbeusekom