Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Add platform interface to prepare for migration to federated architecture #4697

Merged
merged 15 commits into from
Feb 14, 2022
Merged

[local_auth] Add platform interface to prepare for migration to federated architecture #4697

merged 15 commits into from
Feb 14, 2022

Conversation

BeMacized
Copy link
Contributor

@BeMacized BeMacized commented Jan 26, 2022 •
edited
Loading

This PR is the first in a series to move the local_auth plugin to a federated architecture.

  1. Move local_auth into a subfolder and add a platform interface
  2. Add native implementations for the interface
  3. Refactor app facing plugin to make use of the platform interface and native implementations.
    ([local_auth] Refactor package to make use of new platform interface and native implementations #4701)

Relevant issues:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

This was referenced Jan 26, 2022
Closed
Merged
Merged
@BeMacized
Copy link
Contributor Author

The failing federated_safety check should not be applicable here, as the app facing package does not yet make use of the platform interface.

stuartmorgan-g
stuartmorgan-g suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing federated_safety check should not be applicable here, as the app facing package does not yet make use of the platform interface.

This is true, but I'd rather we only override it when we really need to, and here there's a trivial solution of just doing the move as a separate initial PR before adding the platform interface package.

@BeMacized
Copy link
Contributor Author

This is true, but I'd rather we only override it when we really need to, and here there's a trivial solution of just doing the move as a separate initial PR before adding the platform interface package.

Alright, this PR should now only contain the changes for the platform interface. The moved files have been taken care of separately.

stuartmorgan-g
stuartmorgan-g suggested changes Jan 28, 2022
View reviewed changes
stuartmorgan-g
stuartmorgan-g suggested changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn, I have a couple of renames that I didn't think to suggest last time.

stuartmorgan-g
stuartmorgan-g suggested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

stuartmorgan-g
stuartmorgan-g approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Doh, wrong button)

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 14, 2022
@fluttergithubbot fluttergithubbot merged commit 2efdee1 into flutter:main Feb 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
2efdee1e7 [local_auth] Add platform interface to prepare for migratio…
81f2fef 
…n to federated architecture (flutter/plugins#4697)
@BeMacized BeMacized mentioned this pull request Apr 8, 2022
Merged
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
p: local_auth waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeMacized @stuartmorgan-g @fluttergithubbot