[in_app_purchase] Replace errorColor to land deprecations
#6377
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Is that necessary since this only touches example code? |
|
test-exempt: refactor with no semantic change |
example/lib/main.dart is published on pub.dev, so this should have been published (the repo tooling knows which example file changes require publishing and which don't, so wouldn't have flagged it otherwise). People look at, and copy from, example code on pub.dev, so we don't generally want to leave deprecated code there. |
|
I see, should I create a separate PR to bump the version and add a changelog entry? |
|
It's not critical in this case, just please don't override the checks in the future without checking with #hackers-ecosystem first (unless you're certain it's a false-positive). |
|
Gotcha. Please consider updating https://github.com/flutter/plugins/blob/main/script/tool/lib/src/version_check_command.dart#L563-L586 |
Do you have specific suggestions for updates? It currently says to use the override of it's a false positive, which is correct. |
|
Checking with
Specifically checking with the Discord channel if that's expected |
|
It doesn't have to specifically be the Discord channel, that was just a suggestion for where to ask; asking your reviewer would also work. I just meant, please don't unilaterally decide that it's a false positive if you don't actually know. If you aren't sure, the right thing to do is to make sure you get an answer before overriding a check. |
…6377) * Replace `errorColor` to land deprecations * x * x
…6377) * Replace `errorColor` to land deprecations * x * x
…6377) * Replace `errorColor` to land deprecations * x * x
…6377) * Replace `errorColor` to land deprecations * x * x
…6377) * Replace `errorColor` to land deprecations * x * x
…6377) * Replace `errorColor` to land deprecations * x * x
Anticipate deprecations from flutter/flutter#110848
Related flutter/flutter#91772
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.