This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[local_auth] Fix device credential only check for API < 30 #6522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacktty
reviewed
Oct 7, 2022
| @@ -274,6 +274,7 @@ private boolean canAuthenticateWithDeviceCredential() { | |||
| if (Build.VERSION.SDK_INT < 30) { | |||
| // Checking/setting device credential only authentication is not allowed before API 11, | |||
| // so check for presence of PIN, pattern, or password instead. | |||
| if (keyguardManager == null) return false; | |||
| return keyguardManager.isDeviceSecure(); | |||
There was a problem hiding this comment.
@camsim99 I think u need to update the code to
iif (Build.VERSION.SDK_INT >= 16 30 && Build.VERSION.SDK_INT < 30) {
keyguardManager.isDeviceSecure() only works on M and above.
or you can just use what i wrote before
private boolean canAuthenticateWithDeviceCredential() {
//supports from Android 23 onwards
if ( Build.VERSION.SDK_INT >= Build.VERSION_CODES.R ) {
if (biometricManager == null) return false;
return biometricManager.canAuthenticate(BiometricManager.Authenticators.DEVICE_CREDENTIAL)
== BiometricManager.BIOMETRIC_SUCCESS;
}else if ( Build.VERSION.SDK_INT >= Build.VERSION_CODES.M ) {
if (keyguardManager == null) return false;
return keyguardManager.isDeviceSecure();
}
return false;
}
There was a problem hiding this comment.
We actually don't authenticate at all below API 23 (M) in order to be compatible with the biometrics library:
You are right about needing an explicit check for that, so I refactored the code a bit.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#111025.
Changes check for ability to authenticate with device credentials to check for device credentials and biometrics, since as per the documentation, checking for device only authentication is not supported before API 30.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.