Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make in-season and not-in-season cards different #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2019
Merged

Make in-season and not-in-season cards different #67

merged 2 commits into from
Apr 10, 2019

Conversation

xster
Copy link
Member

@xster xster commented Apr 8, 2019 •
edited
Loading

ezgif com-video-to-gif

You'll have to exercise some artistic taste on top of this but it looks like this

Fixes flutter/flutter#30737

Tangentially fixes flutter/flutter#30511

@xster xster requested a review from RedBrogdon April 8, 2019 21:23
@xster xster mentioned this pull request Apr 8, 2019
Closed
RedBrogdon
RedBrogdon approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@RedBrogdon RedBrogdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments.

How does this affect later plans to use the veggie cards as heroes on the way to the detail screen? Is there a way to reach into the cards and lerp the saturation as the transition progresses?

veggieseasons/lib/screens/list.dart Outdated

return DecoratedBox(
decoration: BoxDecoration(color: Color(0xffffffff)),
child: ListView(
children: rows,
child: CupertinoScrollbar(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this isn't in the Cupertino Widget Gallery? I didn't know it existed.

https://flutter.dev/docs/development/ui/widgets/cupertino

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't mean to keep this in. We'd need to fix flutter/flutter#13253 first. I'll add it to the catalog tomorrow though.

veggieseasons/lib/widgets/veggie_card.dart Outdated
colorFilter: isInSeason
? null
// 222222 is a random color that has low color saturation.
: ColorFilter.mode(Color(0xFF222222), BlendMode.saturation),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been sticking random colors like this in styles.dart. Actually, ColorFilter has a const constructor, so you can probably just put the whole filter in there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sure. Done

@xster
Copy link
Member Author

xster commented Apr 10, 2019

How does this affect later plans to use the veggie cards as heroes on the way to the detail screen?

Heros can go from whatever dimension to whatever dimension showing whatever we want in the process.

Is there a way to reach into the cards and lerp the saturation as the transition progresses?

Yes, we'd have to do a simple framework tweak on DecorationImage (could be your PR :D) though maybe it'd be cool to leave it desaturated too for off-season veggies.

@xster xster merged commit 46a62e2 into flutter:master Apr 10, 2019
@xster xster deleted the differentiate-cards branch April 10, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedBrogdon RedBrogdon RedBrogdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Veggie Season] Not clear which veggies are in season and which aren't in the main feed Scrolling glitches with ListView on iOS
2 participants
@xster @RedBrogdon