Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add PHP Coding Standards Fixer in CI #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2023
Merged

Add PHP Coding Standards Fixer in CI #1196

merged 6 commits into from
Jul 21, 2023

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Jul 21, 2023 •
edited
Loading

In the same logic as adding PHPStan (see #1193) to make Geocoder PHP code more clean and consistent across the different providers, plugins, ... I suggest to also implement PHP Coding Standards Fixer with @Symfony ruleset.

@jbelien jbelien requested review from Nyholm and norkunas July 21, 2023 09:20
@jbelien jbelien self-assigned this Jul 21, 2023
@norkunas
Copy link
Member

I'd suggest to use php-cs-fixer/shim 🙂

norkunas
norkunas reviewed Jul 21, 2023
View reviewed changes
@jbelien
Copy link
Member Author

jbelien commented Jul 21, 2023 •
edited
Loading

I'd suggest to use php-cs-fixer/shim 🙂

Oh, I didn't know that. I'll make the change! 👍
Done in 79da409

@jbelien jbelien marked this pull request as ready for review July 21, 2023 09:31
@jbelien jbelien merged commit 30ae77f into master Jul 21, 2023
@jbelien jbelien deleted the php-cs-fixer branch July 21, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

@jbelien jbelien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelien @norkunas