fix: Sentry Cocoa framework version #4411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimal test app with instructions: https://github.com/jpnurmi/SentryMauiApp |
jpnurmi
commented
Aug 5, 2025
jpnurmi
commented
Aug 5, 2025
3 tasks
|
With
https://github.com/jpnurmi/SentryMauiApp/actions/runs/16780386537/job/47521803035 |
This was referenced Aug 6, 2025
Flash0ver
reviewed
Aug 7, 2025
Flash0ver
reviewed
Aug 7, 2025
Flash0ver
reviewed
Aug 7, 2025
Co-authored-by: Stefan Pölz <[email protected]>
jamescrosswell
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Since all the tests pass, I'm assuming this is good to go.
Thanks @jpnurmi !
|
Thanks! Yes, this is ready to go, and safe to merge as it only adds a version suffix to the |
This was referenced Aug 15, 2025
This was referenced Sep 1, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a consuming app upgrades or downgrades Sentry .NET, it might be left with an incorrect, stale version of the Sentry Cocoa framework in the intermediate output directory.
For example, an app built with Sentry .NET 5.5.1 has Sentry Cocoa 8.39 extracted into the intermediate output directory:
When upgraded to Sentry .NET 5.6.0 without cleaning, the intermediate output directory still contains Sentry Cocoa 8.39 instead of 8.46. Similar problems occur when upgrading from Sentry .NET 5.7.0 to 5.8.0 because
Sentry.Bindings.Cocoadoes not match the stale version of Sentry Cocoa.This PR tries to fix the problem by changing
Sentry.Bindings.Cocoato reference a versioned framework (Sentry-<version>.xcframework) instead ofSentry-Dynamic.xcframework.NOTE: The Xamarin tooling automatically takes care of archiving and extracting
Sentry.Bindings.Cocoa.resources.zip. It is hard to control the name of the ZIP archive ($(AssemblyName).resources), but we can control the name ofSentry-xxx.xcframeworkinside.P.S. Sentry Cocoa bundle version can be checked in
Sentry-Dynamic.xcframework/ios-arm64_x64_64-simulator/Sentry.framework/Info.plist.See also:
#skip-changelog (already released as 5.14.0-alpha.0)