Add Sentry Log feature to Java SDK #4372
Open
+933
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add Sentry Log feature to Java SDK ([#4372](https://github.com/getsentry/sentry-java/pull/4372))If none of the above apply, you can opt out of this check by adding |
lcian
reviewed
May 6, 2025
Comment on lines
+31
to
+32
| // TODO SentryLevel.TRACE does not exists yet | ||
| // log(SentryLevel.TRACE, message, args); |
lcian
reviewed
May 6, 2025
| throws IOException { | ||
| writer.beginObject(); | ||
| writer.name("items").value(logger, items); | ||
| writer.endObject(); |
There was a problem hiding this comment.
I think we are missing the serialization of unknown here
lcian
reviewed
May 6, 2025
| for (Object arg : args) { | ||
| final @NotNull String type = getType(arg); | ||
| attributes.put( | ||
| "sentry.message.parameters." + i, new SentryLogEventAttributeValue(type, arg)); |
There was a problem hiding this comment.
Suggested change
| "sentry.message.parameters." + i, new SentryLogEventAttributeValue(type, arg)); | |
| "sentry.message.parameter." + i, new SentryLogEventAttributeValue(type, arg)); |
lcian
reviewed
May 6, 2025
lcian
reviewed
May 6, 2025
| logger.log(SentryLevel.ERROR, message, exception); | ||
| throw exception; | ||
| } | ||
|
|
There was a problem hiding this comment.
In that case it can probably become @NotNull on SentryLogEvent
lcian
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add API for capturing logs.
💡 Motivation and Context
Partial implementation for #4350
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps