Amend test now that DataFlowCallable != Callable

smowton · smowton · commit 51ebc0bef28e · 2023-04-12T14:15:54.000+01:00
diff --git a/go/ql/test/library-tests/semmle/go/dataflow/CallGraph/viableCallee.ql b/go/ql/test/library-tests/semmle/go/dataflow/CallGraph/viableCallee.ql
@@ -17,10 +17,10 @@ string metadata(Locatable l, string key) {
 
 query predicate missingCallee(DataFlow::CallNode call, FuncDef callee) {
   metadata(call.asExpr(), "callee") = metadata(callee, "name") and
-  not viableCallable(call.asExpr()).getFuncDef() = callee
+  not viableCallable(call.asExpr()).asCallable().getFuncDef() = callee
 }
 
 query predicate spuriousCallee(DataFlow::CallNode call, FuncDef callee) {
-  viableCallable(call.asExpr()).getFuncDef() = callee and
+  viableCallable(call.asExpr()).asCallable().getFuncDef() = callee and
   not metadata(call.asExpr(), "callee") = metadata(callee, "name")
 }

Original file line number	Diff line number	Diff line change
`@@ -17,10 +17,10 @@ string metadata(Locatable l, string key) {`
`17`	`17`
`18`	`18`	`query predicate missingCallee(DataFlow::CallNode call, FuncDef callee) {`
`19`	`19`	`metadata(call.asExpr(), "callee") = metadata(callee, "name") and`
`20`		`- not viableCallable(call.asExpr()).getFuncDef() = callee`
	`20`	`+ not viableCallable(call.asExpr()).asCallable().getFuncDef() = callee`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`query predicate spuriousCallee(DataFlow::CallNode call, FuncDef callee) {`
`24`		`- viableCallable(call.asExpr()).getFuncDef() = callee and`
	`24`	`+ viableCallable(call.asExpr()).asCallable().getFuncDef() = callee and`
`25`	`25`	`not metadata(call.asExpr(), "callee") = metadata(callee, "name")`
`26`	`26`	`}`