Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use bundle URL version as the cache version #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 19, 2020
Merged

Use bundle URL version as the cache version #69

merged 12 commits into from
Jun 19, 2020

Conversation

alexkappa
Copy link
Contributor

@alexkappa alexkappa commented Jun 17, 2020 •
edited
Loading

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

robertbrignull
robertbrignull approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM

@alexkappa alexkappa marked this pull request as ready for review June 19, 2020 09:14
tibbes
tibbes reviewed Jun 19, 2020
View reviewed changes
@alexkappa alexkappa changed the title wip: hash bundle url and use it as the cache version Use bundle URL version as the cache version Jun 19, 2020
chrisgavin
chrisgavin reviewed Jun 19, 2020
View reviewed changes
robertbrignull
robertbrignull reviewed Jun 19, 2020
View reviewed changes
@robertbrignull
Copy link
Contributor

The unit tests look really good to me and look like they validate the behaviour pretty well. I'm running a quick test locally too just to make sure, but I don't expect it to fail.

robertbrignull
robertbrignull approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and confirmed it's downloading and using the correct versions now

root@02c171a6cfa5:/actions-runner# ls _work/_tool/CodeQL/
0.0.0-20200427  0.0.0-20200601  1.0.0

Unless anyone else has comments I think this is ready to merge whenever you want.

Alex Kalyvitis and others added 2 commits June 19, 2020 13:27
@alexkappa alexkappa merged commit 74f864b into master Jun 19, 2020
@github-actions github-actions bot mentioned this pull request Jun 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgavin chrisgavin chrisgavin left review comments

@tibbes tibbes tibbes left review comments

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexkappa @robertbrignull @chrisgavin @tibbes