-
Notifications
You must be signed in to change notification settings - Fork 366
Merge master into v1 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate sarif against schema before uploading
Usage of Jest was removed in #18
Remove jest config as tests use Ava now
Co-authored-by: Alex Kalyvitis <[email protected]>
Add simple instructions for sending repository dispatch event
Add matrix input to init action
Before this change, config-utils.ts › load non-empty input was failing on Mac with: The configuration file "/var/folders/gx/y8v1507s29d97m1r_5kq0s000000gn/T/codeql-action-oum66d/input" is invalid: property "queries.uses" is invalid as the local path "" is outside of the repository The reason is that the tmp directory (which is where the config file was put by the test) was a symlink.
Configure VSCode to ignore transpiled JavaScript
Ensure config path comparisons don't fail where workspace path is a symlink
Co-authored-by: Robert <[email protected]>
Use bundle URL version as the cache version
I've had a look through the PRs again and I think this is good to merge. Everything here is safe to go into the v1 branch. Probably the change most likely to cause issues is #39, but this is only moving errors further up the pipeline so they're more visible. The analysis would still have failed. Also the changes made in #61 should have helped avoid this. |
robertbrignull
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 74f864b into v1
Conductor for this PR is @robertbrignull
Contains the following pull requests: