Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixing sorting of PRs #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Fixing sorting of PRs #72

merged 2 commits into from
Jun 23, 2020

Conversation

robertbrignull
Copy link
Contributor

I made a mistake here as I thought sorted updated the list in-place, but that's not true. So the PRs in #71 weren't sorted as they were inteneded to have been.

I got suspicious as to why I was the conductor, when I think it should have been @alexkappa

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Copy link
Contributor

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sampart sampart changed the base branch from master to main June 23, 2020 08:55
@robertbrignull robertbrignull merged commit 8e098cb into main Jun 23, 2020
@github-actions github-actions bot mentioned this pull request Jun 29, 2020
@robertbrignull robertbrignull deleted the release-sorting branch April 23, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants